[GitHub] [beam] pcoet commented on a diff in pull request #17676: Adding eslint and lint configuration to TypeScript SDK

[GitBox <gi...@apache.org>]

pcoet commented on code in PR #17676:
URL: https://github.com/apache/beam/pull/17676#discussion_r874080416


##########
sdks/typescript/package.json:
##########
@@ -21,16 +21,20 @@
     "test": "mocha dist/test",
     "codecovTest": "istanbul cover mocha dist/test --reporter lcovonly -- -R spec && codecov",
     "prettier": "prettier --write src/",
-    "prettier-check": "prettier --check src/"
+    "prettier-check": "prettier --check src/",
+    "lint": "eslint . --ext .ts"
   },
   "dependencies": {
     "@grpc/grpc-js": "^1.4.6",
     "@protobuf-ts/grpc-transport": "^2.1.0",
     "@protobuf-ts/plugin": "^2.1.0",
+    "@typescript-eslint/eslint-plugin": "^5.23.0",

Review Comment:
   Yes, they should. Good catch. Fixed. Thanks!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org