You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Erick Erickson (JIRA)" <ji...@apache.org> on 2017/10/14 04:13:01 UTC

[jira] [Updated] (SOLR-11488) Do not allow collections and aliases to have the same name

     [ https://issues.apache.org/jira/browse/SOLR-11488?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Erick Erickson updated SOLR-11488:
----------------------------------
    Attachment: SOLR-11488.patch

Preliminary patch. The actual code changes are pretty minimal. I did add a method to Aliases.java, not sure I like the name or if it's in the right place, but it's late Friday.

I have not run precommit or all tests on this yet, and the patch doesn't contain documentation fixes, I'll do these later if we move forward with this..

Let me know what people think, particularly [~dsmiley].

> Do not allow collections and aliases to have the same name
> ----------------------------------------------------------
>
>                 Key: SOLR-11488
>                 URL: https://issues.apache.org/jira/browse/SOLR-11488
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Erick Erickson
>            Assignee: Erick Erickson
>         Attachments: SOLR-11488.patch
>
>
> Currently you can define an alias with the same name as a collection and (perhaps) vice-versa. The more I think about this the worse idea it seems. See the discussion at the linked JIRAs.
> Proposal: We should fail to create a collection if an alias already exists with the same name and vice-versa.
> This should depend on SOLR-11444 and supersede SOLR-11218, this JIRA will include tests that define the intended behavior making SOLR-11218 obsolete. We'll close SOLR-11218 as "contained by" this JIRA.
> This _will_ take away the ability to
> 1> create a collection, call it "old" and index to it.
> 2> decide you want to change the schema
> 3> create a collection call it "new" and index to it.
> 4> create an alias old->new THIS WILL FAIL.
> 5> delete the "old" collection
> People will have to create an alias pointing to "old" and change their clients to use it, then they can do step 4 above....
> This is kind of a pain, but much better than following an alias and deleting "new". I'd also argue that it's a maintenance problem to have collections and aliases with the same name.
> What do people think? I'll try to work up a preliminary patch. If we do this, we should probably coordinate committing this and SOLR-11444 and I'll also change the docs to reflect this and upgrade notes.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org