You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2023/01/03 21:17:26 UTC

[GitHub] [tvm] tkonolige opened a new pull request, #13688: [MetaSchedule] Add pass instrument to MetaSchedule api

tkonolige opened a new pull request, #13688:
URL: https://github.com/apache/tvm/pull/13688

   Add the `instrument` parameter from the `PassContext` api to the meta schedule tuning api.
   
   @masahi @junrushao 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [tvm] masahi commented on pull request #13688: [MetaSchedule] Add pass instrument to MetaSchedule api

Posted by GitBox <gi...@apache.org>.
masahi commented on PR #13688:
URL: https://github.com/apache/tvm/pull/13688#issuecomment-1370242686

   What's the use case of this param during tuning?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [tvm] masahi commented on pull request #13688: [MetaSchedule] Add pass instrument to MetaSchedule api

Posted by GitBox <gi...@apache.org>.
masahi commented on PR #13688:
URL: https://github.com/apache/tvm/pull/13688#issuecomment-1370265836

   Is this needed only if https://github.com/apache/tvm/pull/13470 doesn't get in?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [tvm] masahi merged pull request #13688: [MetaSchedule] Add pass instrument to MetaSchedule api

Posted by GitBox <gi...@apache.org>.
masahi merged PR #13688:
URL: https://github.com/apache/tvm/pull/13688


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [tvm] masahi commented on pull request #13688: [MetaSchedule] Add pass instrument to MetaSchedule api

Posted by GitBox <gi...@apache.org>.
masahi commented on PR #13688:
URL: https://github.com/apache/tvm/pull/13688#issuecomment-1379531047

   Hopefully we overhaul the current API to clean up mostly unused parameters.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [tvm] tkonolige commented on pull request #13688: [MetaSchedule] Add pass instrument to MetaSchedule api

Posted by GitBox <gi...@apache.org>.
tkonolige commented on PR #13688:
URL: https://github.com/apache/tvm/pull/13688#issuecomment-1370261485

   A couple use cases:
   - Profiling time spent in each pass during task extraction
   - Enabling or disabling passes based on a certain context (a feature of the pass instrument api)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [tvm] tkonolige commented on pull request #13688: [MetaSchedule] Add pass instrument to MetaSchedule api

Posted by GitBox <gi...@apache.org>.
tkonolige commented on PR #13688:
URL: https://github.com/apache/tvm/pull/13688#issuecomment-1379524724

   @masahi How about we merge this as #13470 is still in discussion?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [tvm] tvm-bot commented on pull request #13688: [MetaSchedule] Add pass instrument to MetaSchedule api

Posted by GitBox <gi...@apache.org>.
tvm-bot commented on PR #13688:
URL: https://github.com/apache/tvm/pull/13688#issuecomment-1370233719

   <!---bot-comment-->
   
   Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @-ing them in a comment.
   
   <!--bot-comment-ccs-start-->
    * cc @Hzfengsy, @elvin-n, @junrushao, @quic-sanirudh <sub>See [#10317](https://github.com/apache/tvm/issues/10317) for details</sub><!--bot-comment-ccs-end-->
   
   <sub>Generated by [tvm-bot](https://github.com/apache/tvm/blob/main/ci/README.md#github-actions)</sub>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [tvm] tkonolige commented on pull request #13688: [MetaSchedule] Add pass instrument to MetaSchedule api

Posted by GitBox <gi...@apache.org>.
tkonolige commented on PR #13688:
URL: https://github.com/apache/tvm/pull/13688#issuecomment-1370266291

   Yes that is correct.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org