[GitHub] [hadoop-ozone] avijayanhwx commented on a change in pull request #689: HDDS-3183. Deprecate old Recon HTTP Server Keytab config key.

[GitBox <gi...@apache.org>]

avijayanhwx commented on a change in pull request #689: HDDS-3183. Deprecate old Recon HTTP Server Keytab config key.
URL: https://github.com/apache/hadoop-ozone/pull/689#discussion_r393192877
 
 

 ##########
 File path: hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/ReconServer.java
 ##########
 @@ -66,6 +67,9 @@ public static void main(String[] args) {
   @Override
   public Void call() throws Exception {
     OzoneConfiguration ozoneConfiguration = createOzoneConfiguration();
+    Configuration.addDeprecation(
+        ReconServerConfigKeys.OZONE_RECON_HTTP_KEYTAB_FILE_OLD,
 
 Review comment:
   Maybe we can add a method 'addConfigurationOverrides' in the ConfigurationProvider provider and move this logic there? When we have more deprecated keys in the future, it may be easier to maintain them there. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org