[GitHub] [trafficserver] maskit commented on pull request #7814: Cleanup: Remove a meaningless Http2Stream::do_io_close() call

[GitBox <gi...@apache.org>]

maskit commented on pull request #7814:
URL: https://github.com/apache/trafficserver/pull/7814#issuecomment-839514858


   Is `do_io_close` called at somewhere else with `closed` flag off? A right way might be setting `closed` flag `true` after calling `do_io_close`.
   
   Having this pattern below at two places seems very odd -- it implies calling either of those is enough but I think `do_io_close` should be always called if `do_io_read/write()` was called, like `open()` and `close()` system calls.
   ```
   if (closed) {
     closed = true;
     ...
   }
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org