You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by becketqin <gi...@git.apache.org> on 2016/02/01 02:46:15 UTC
[GitHub] kafka pull request: KAFKA-3179 Fix seek on compressed messages
GitHub user becketqin opened a pull request:
https://github.com/apache/kafka/pull/842
KAFKA-3179 Fix seek on compressed messages
The fix itself is simple.
Some explanation on unit tests. Currently we the vast majority of unit test is running with uncompressed messages. I was initially thinking about run all the tests using compressed messages. But it seems uncompressed messages are necessary in a many test cases because we need the bytes sent and appended to the log to be predictable. In most of other cases, it does not matter whether the message is compressed or not, and compression will slow down the unit test. So I just added one method in the BaseConsumerTest to send compressed messages whenever we need it.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/becketqin/kafka KAFKA-3179
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/842.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #842
----
commit 0f5cd3184f63ba9ec93c4450f81e0222ae96b422
Author: Jiangjie Qin <be...@gmail.com>
Date: 2016-02-01T01:38:37Z
KAFKA-3179 Fix seek on compressed messages
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] kafka pull request: KAFKA-3179 Fix seek on compressed messages
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/kafka/pull/842
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---