[GitHub] [geode-native] pivotal-jbarrett commented on a change in pull request #726: GEODE-8847: Change from boost::asio asynchronous name resolution to s…

[GitBox <gi...@apache.org>]

pivotal-jbarrett commented on a change in pull request #726:
URL: https://github.com/apache/geode-native/pull/726#discussion_r561227009



##########
File path: cppcache/src/TcpConn.cpp
##########
@@ -113,16 +113,11 @@ TcpConn::TcpConn(const std::string ipaddr,
 TcpConn::TcpConn(const std::string host, uint16_t port,
                  std::chrono::microseconds timeout, int32_t maxBuffSizePool)
     : socket_{io_context_} {
-  auto beforeResolvePoint = std::chrono::system_clock::now();
-  auto results = resolve(host, port, timeout);
-  auto elapsedTime = std::chrono::duration<double, std::micro>(
-      std::chrono::system_clock::now() - beforeResolvePoint);
+  auto results = resolve(host, port);

Review comment:
       I believe it is in intentional that the resolve of the host is also part of the connection timeout. Now it looks like resolve could take an indeterminate amount of time followed by only connect limited by timeout.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org