You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/05/19 20:38:40 UTC

[GitHub] [arrow] nevi-me commented on a change in pull request #7204: ARROW-8831: [Rust] change simd_compare_op in comparison kernel to use bitmask SIMD operation to significantly improve performance

nevi-me commented on a change in pull request #7204:
URL: https://github.com/apache/arrow/pull/7204#discussion_r427582826



##########
File path: rust/arrow/src/compute/kernels/comparison.rs
##########
@@ -210,6 +210,10 @@ where
     T: ArrowNumericType,
     F: Fn(T::Simd, T::Simd) -> T::SimdMask,
 {
+    use crate::buffer::MutableBuffer;

Review comment:
       Our convention has been to put imports at the beginning of the file. I can see why you put them here, so it's fine.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org