You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/01/25 03:16:43 UTC

[GitHub] [cloudstack] harikrishna-patnala commented on a change in pull request #4611: UI Storage Pool Tags: unable to delete last tag

harikrishna-patnala commented on a change in pull request #4611:
URL: https://github.com/apache/cloudstack/pull/4611#discussion_r563441872



##########
File path: ui/src/views/AutogenView.vue
##########
@@ -957,7 +957,8 @@ export default {
             if (param.name !== key) {
               continue
             }
-            if (input === undefined || input === null || input === '') {
+            if (input === undefined || input === null || (input === '' &&
+              !['updateStoragePool', 'updateHost'].includes(action.api))) {

Review comment:
       @Pearl1594 we have physical networks tags also, I just checked we could not delete the tag on physical network too, can you please add that here.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org