[GitHub] [incubator-superset] villebro edited a comment on issue #7643: 7620: Start removing dependencies on requests

[GitBox <gi...@apache.org>]

villebro edited a comment on issue #7643: 7620: Start removing dependencies on requests
URL: https://github.com/apache/incubator-superset/pull/7643#issuecomment-508556124
 
 
   Hmm, I'm kind of split on this one, but starting to lean towards just removing the backend stuff should be enough and deal with the frontend later. Removing the UI stuff is a much bigger can of worms than I had anticipated, and there is major risk of feature creep that will derail the originally neatly limited scope of just getting a few deps out of `setup.py` and `requirements.txt`. I vote for removing the last commit and going back to the last one that cleared CI.
   
   One thing that might clean up the code somewhat is to try to import `pydruid` at the earliest possible moment, e.g. `superset/__init__.py` and setting an app config flag as false if `pydruid` isn't present. Later on one would only need to check that, instead of doing a bunch of trying and catching on the imports. But like I said I'm not really sure about this one, and would now just try to finish this PR as quickly as possible, but if you feel this might have merit and if it's quick to implement then it might make the code slightly cleaner.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org