You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@systemds.apache.org by GitBox <gi...@apache.org> on 2020/09/29 04:02:29 UTC
[GitHub] [systemds] j143 opened a new pull request #1072: [MINOR][DOC] Update header links and image files
j143 opened a new pull request #1072:
URL: https://github.com/apache/systemds/pull/1072
- Update header links.
- Add convolution image files
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemds] Baunsgaard commented on pull request #1072: [MINOR][DOC] Update header links and image files
Posted by GitBox <gi...@apache.org>.
Baunsgaard commented on pull request #1072:
URL: https://github.com/apache/systemds/pull/1072#issuecomment-700666199
Hi Janathan, this does not work once you go into any sub-page,
since each of the links refer to relative paths from where you are.
This means that from the main page it links correctly, from lets say DML Language Reference it does not.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemds] Baunsgaard commented on pull request #1072: [MINOR][DOC] Update header links and image files
Posted by GitBox <gi...@apache.org>.
Baunsgaard commented on pull request #1072:
URL: https://github.com/apache/systemds/pull/1072#issuecomment-701463735
thanks for the PR i have merged it now. I did some minor modifications such as adding an option to go back to the main overview page..
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemds] j143 commented on a change in pull request #1072: [MINOR][DOC] Update header links and image files
Posted by GitBox <gi...@apache.org>.
j143 commented on a change in pull request #1072:
URL: https://github.com/apache/systemds/pull/1072#discussion_r496729175
##########
File path: docs/_includes/header.html
##########
@@ -35,10 +35,37 @@
</div>
<nav class="navbar-collapse collapse">
<ul class="nav navbar-nav navbar-right">
- <li><a href=".{% if page.path contains 'site' %}/..{% endif %}/">Overview</a></li>
- <li><a href="https://github.com/apache/systemds">GitHub</a></li>
<li class="dropdown">
- <a href="#" class="dropdown-toggle" data-toggle="dropdown">API Docs<b class="caret"></b></a>
+ <a href="#" class="dropdown-toggle" data-toggle="dropdown">Overview<b class="caret"></b></a>
+ <ul class="dropdown-menu" role="menu">
+ <li><b>Running SystemDS:</b></li>
+ <!--<li><a href="spark-mlcontext-programming-guide">Spark MLContext</a></li>-->
+ <!--<li><a href="site/spark-batch-mode">Spark Batch Mode</a>
+ <li><a href="site/hadoop-batch-mode">Hadoop Batch Mode</a>-->
+ <li><a href="site/run">Standalone Guide</a></li>
+ <!--<li><a href="site/jmlc">Java Machine Learning Connector (JMLC)</a>-->
+ <li class="divider"></li>
+ <li><b>Language Guides:</b></li>
+ <li><a href="site/dml-language-reference.html">DML Language Reference</a></li>
+ <li class="divider"></li>
+ <li><b>ML Algorithms:</b></li>
+ <li><a href="site/algorithms-reference.html">Algorithms Reference</a></li>
+ <!--<li class="divider"></li>
+ <li><b>Tools:</b></li>
+ <li><a href="site/debugger-guide.html">Debugger Guide</a></li>
+ <li><a href="site/developer-tools-systemds.html">IDE Guide</a></li>-->
+ <li class="divider"></li>
+ <li><b>Other:</b></li>
+ <li><a href="https://github.com/apache/systemds/blob/master/CONTRIBUTING.md">Contributing to SystemDS 🡕</a></li>
+ <!--
+ <li><a href="site/engine-dev-guide.html">Engine Developer Guide</a></li>
+ <li><a href="site/troubleshooting-guide.html">Troubleshooting Guide</a></li>
+ <li><a href="site/release-process.html">Release Process</a></li> -->
Review comment:
Happy to remove these.
These are the document pages necessary to be provided in the future. 😃
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemds] Baunsgaard edited a comment on pull request #1072: [MINOR][DOC] Update header links and image files
Posted by GitBox <gi...@apache.org>.
Baunsgaard edited a comment on pull request #1072:
URL: https://github.com/apache/systemds/pull/1072#issuecomment-700666199
Hi @j143, this does not work once you go into any sub-page,
since each of the links refer to relative paths from where you are.
This means that from the main page it links correctly, from lets say DML Language Reference it does not.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemds] Baunsgaard commented on a change in pull request #1072: [MINOR][DOC] Update header links and image files
Posted by GitBox <gi...@apache.org>.
Baunsgaard commented on a change in pull request #1072:
URL: https://github.com/apache/systemds/pull/1072#discussion_r496672497
##########
File path: docs/_includes/header.html
##########
@@ -35,10 +35,37 @@
</div>
<nav class="navbar-collapse collapse">
<ul class="nav navbar-nav navbar-right">
- <li><a href=".{% if page.path contains 'site' %}/..{% endif %}/">Overview</a></li>
- <li><a href="https://github.com/apache/systemds">GitHub</a></li>
<li class="dropdown">
- <a href="#" class="dropdown-toggle" data-toggle="dropdown">API Docs<b class="caret"></b></a>
+ <a href="#" class="dropdown-toggle" data-toggle="dropdown">Overview<b class="caret"></b></a>
+ <ul class="dropdown-menu" role="menu">
+ <li><b>Running SystemDS:</b></li>
+ <!--<li><a href="spark-mlcontext-programming-guide">Spark MLContext</a></li>-->
+ <!--<li><a href="site/spark-batch-mode">Spark Batch Mode</a>
+ <li><a href="site/hadoop-batch-mode">Hadoop Batch Mode</a>-->
+ <li><a href="site/run">Standalone Guide</a></li>
+ <!--<li><a href="site/jmlc">Java Machine Learning Connector (JMLC)</a>-->
+ <li class="divider"></li>
+ <li><b>Language Guides:</b></li>
+ <li><a href="site/dml-language-reference.html">DML Language Reference</a></li>
+ <li class="divider"></li>
+ <li><b>ML Algorithms:</b></li>
+ <li><a href="site/algorithms-reference.html">Algorithms Reference</a></li>
+ <!--<li class="divider"></li>
+ <li><b>Tools:</b></li>
+ <li><a href="site/debugger-guide.html">Debugger Guide</a></li>
+ <li><a href="site/developer-tools-systemds.html">IDE Guide</a></li>-->
+ <li class="divider"></li>
+ <li><b>Other:</b></li>
+ <li><a href="https://github.com/apache/systemds/blob/master/CONTRIBUTING.md">Contributing to SystemDS 🡕</a></li>
+ <!--
+ <li><a href="site/engine-dev-guide.html">Engine Developer Guide</a></li>
+ <li><a href="site/troubleshooting-guide.html">Troubleshooting Guide</a></li>
+ <li><a href="site/release-process.html">Release Process</a></li> -->
Review comment:
Also I would remove these uncommented links
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemds] j143 commented on pull request #1072: [MINOR][DOC] Update header links and image files
Posted by GitBox <gi...@apache.org>.
j143 commented on pull request #1072:
URL: https://github.com/apache/systemds/pull/1072#issuecomment-700717507
> this does not work once you go into any sub-page,
> since each of the links refer to relative paths from where you are.
Is it possible to correct the links based on how you intend the website to deploy. Can you do that? Thanks.
cc @Baunsgaard
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemds] Baunsgaard closed pull request #1072: [MINOR][DOC] Update header links and image files
Posted by GitBox <gi...@apache.org>.
Baunsgaard closed pull request #1072:
URL: https://github.com/apache/systemds/pull/1072
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org