[GitHub] [shardingsphere] TeslaCN commented on a diff in pull request #18893: listen on specified addresses

[GitBox <gi...@apache.org>]

TeslaCN commented on code in PR #18893:
URL: https://github.com/apache/shardingsphere/pull/18893#discussion_r914595822


##########
shardingsphere-distribution/shardingsphere-proxy-distribution/src/main/resources/bin/start.sh:
##########
@@ -61,10 +61,23 @@ JAVA_MEM_OPTS=" -server -Xmx2g -Xms2g -Xmn1g -Xss1m -XX:AutoBoxCacheMax=4096 -XX
 
 MAIN_CLASS=org.apache.shardingsphere.proxy.Bootstrap
 
+unset -v PORT
+unset -v ADDRESSES
+unset -v CONF_PATH
+
 print_usage() {
-    echo "usage: start.sh [port] [config_dir]"
+    echo "usage:"
+    echo "start.sh [port] [config_dir]"
     echo "  port: proxy listen port, default is 3307"
-    echo "  config_dir: proxy config directory, default is conf"
+    echo "  config_dir: proxy config directory, default is 'conf'"
+    echo ""
+    echo "start.sh [-h addresses] [-p port] [-c /path/to/conf]"

Review Comment:
   We have already changed the `-h`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org