You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/03/25 12:21:51 UTC

[GitHub] [skywalking] jlstephens89 commented on pull request #8736: added the ignore rule for thread safety

jlstephens89 commented on pull request #8736:
URL: https://github.com/apache/skywalking/pull/8736#issuecomment-1078977355


   > https://lift.sonatype.com/results/github.com/doddi/skywalking/01FYY8BBCACQ1W0HNQ9HWDBNWS?t=ErrorProne%7CSameNameButDifferent
   > 
   > Another question is, this is a common use of `@Slf4j`, why is this showing up?
   > 
   > https://github.com/doddi/skywalking/blob/2a1e480d18605d89b62e12e1a020241133ad5dfa/apm-webapp/src/main/java/org/apache/skywalking/oap/server/webapp/GlobalErrorWebExceptionHandler.java#L34
   
   @wu-sheng @kezhenxu94 Looks like there might be an issue with Lombok and ErrorProne for this particular finding ([details](https://github.com/google/error-prone/issues/2273)). For now I think we should disable this finding as it's more of a suggestion than a true issue. I'm testing the config change out on another branch and then will merge into this one if it works correctly.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org