You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@auron.apache.org by "xumingming (via GitHub)" <gi...@apache.org> on 2025/12/01 08:06:45 UTC

[PR] [AURON #1679] Fail fast when auron is enabled but shuffle manager is not a supported one [auron]

xumingming opened a new pull request, #1682:
URL: https://github.com/apache/auron/pull/1682

   # Which issue does this PR close?
   
   Closes #1679 .
   
    # Rationale for this change
   
   We should fast fail rather than return incorrect results for unsupported shuffle manager.
   
   # What changes are included in this PR?
   
   
   # Are there any user-facing changes?
   
   If shuffle manager is not configured correctly, exception will be thrown.
   
   # How was this patch tested?
   
   Added UT.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@auron.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [AURON #1679] Fail fast when auron is enabled but shuffle manager is not a supported one [auron]

Posted by "xumingming (via GitHub)" <gi...@apache.org>.
xumingming closed pull request #1682: [AURON #1679] Fail fast when auron is enabled but shuffle manager is not a supported one
URL: https://github.com/apache/auron/pull/1682


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@auron.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [AURON #1679] Fail fast when auron is enabled but shuffle manager is not a supported one [auron]

Posted by "cxzl25 (via GitHub)" <gi...@apache.org>.
cxzl25 commented on code in PR #1682:
URL: https://github.com/apache/auron/pull/1682#discussion_r2580881106


##########
spark-extension/src/main/scala/org/apache/spark/sql/auron/AuronSparkSessionExtension.scala:
##########
@@ -68,6 +74,14 @@ case class AuronColumnarOverrides(sparkSession: SparkSession) extends ColumnarRu
   override def preColumnarTransitions: Rule[SparkPlan] = {
     new Rule[SparkPlan] {
       override def apply(sparkPlan: SparkPlan): SparkPlan = {
+        val shuffleManager = SparkEnv.get.shuffleManager
+        if (SparkEnv.get.conf.get(auronEnabledKey) &&
+          !isShuffleManagerSupported(shuffleManager)) {

Review Comment:
   https://github.com/apache/auron/pull/1628



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@auron.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org