[GitHub] [airflow] mik-laj commented on a change in pull request #9276: Add airflow upgrade_check command (MVP)

[GitBox <gi...@apache.org>]

mik-laj commented on a change in pull request #9276:
URL: https://github.com/apache/airflow/pull/9276#discussion_r440116122



##########
File path: airflow/upgrade/rules/base_rule.py
##########
@@ -0,0 +1,36 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+from abc import ABCMeta, abstractmethod
+from typing import List
+
+
+class BaseRule(metaclass=ABCMeta):
+    @property
+    @abstractmethod
+    def title(self) -> str:
+        """Short one-line summary"""
+        pass
+
+    @property
+    @abstractmethod
+    def description(self) -> str:
+        """A long description explaining the problem in detail. This can be an entry from UPDATING.md file."""
+        pass
+
+    def check(self) -> List[str]:

Review comment:
       The problem stores references to the rule, so the problem must be initiated as follows:  ``Problem(rule=rule, message=message)``.  It seemed too talkative to me right now. This code will be repeated in every rule.  Now the rules are a little easier to write. We can add support for returning it in the future when we need it. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org