You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Thomas Tauber-Marshall (Code Review)" <ge...@cloudera.org> on 2018/04/27 04:34:38 UTC

[native-toolchain-CR] Improve build-kudu-only.sh

Thomas Tauber-Marshall has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10227


Change subject: Improve build-kudu-only.sh
......................................................................

Improve build-kudu-only.sh

This patch makes various improvements related to running
build-kudu-only.sh:
- Previously, build-kudu-only.sh would download the toolchain
  components that Kudu relies on from S3. This patch adds the option
  to copy the components from an existing toolchain, determined by
  looking for the environment variable $IMPALA_TOOLCHAIN.
- Previously, build-kudu-only.sh required that BUILD_LABEL be set.
  This patch adds a utility function to automatically detect the
  correct value of BUILD_LABEL.
- Adds the ability to override BUILD_THREADS.
- Adds the variable KUDU_MAKE_FLAGS to allow for adding addition flags
  to Kudu's make.
- Adds the variable KUDU_INSTALL_PATH, which allows users to specify
  a path within Kudu's build directory in which to install Kudu.
- Removes the downloading/building of autotools from
  build-kudu-only.sh, as they are not actually used when building
  Kudu.

Change-Id: I6b76e6fbd2f7be333a0f9580128ec9f681b3ddf8
---
M build-kudu-only.sh
M functions.sh
M init.sh
M source/kudu/build.sh
4 files changed, 129 insertions(+), 22 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/27/10227/1
-- 
To view, visit http://gerrit.cloudera.org:8080/10227
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6b76e6fbd2f7be333a0f9580128ec9f681b3ddf8
Gerrit-Change-Number: 10227
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>

[native-toolchain-CR] Improve build-kudu-only.sh

Posted by "Thomas Tauber-Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Tauber-Marshall has abandoned this change. ( http://gerrit.cloudera.org:8080/10227 )

Change subject: Improve build-kudu-only.sh
......................................................................


Abandoned

decided to go in a different direction
-- 
To view, visit http://gerrit.cloudera.org:8080/10227
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: I6b76e6fbd2f7be333a0f9580128ec9f681b3ddf8
Gerrit-Change-Number: 10227
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>