You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org> on 2020/08/11 13:59:44 UTC
[Impala-ASF-CR] IMPALA-10066: Ugly hotfix for subtle bug in Pexpect
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16325
Change subject: IMPALA-10066: Ugly hotfix for subtle bug in Pexpect
......................................................................
IMPALA-10066: Ugly hotfix for subtle bug in Pexpect
IMPALA-10066 breaks our builds right now. We get an
exception from a pexpect wait() funciton. The exception says
the child process is already dead. Interestingly there is no
problem with the same wait() function a couple of lines after.
For a quick and ugly fix I removed the wait() call since it is
not too important regarding to the test.
The bug needs further investigation.
Change-Id: I035708d627d42deb89bb34423b150bf9567d0f22
---
M tests/shell/test_shell_interactive.py
1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/25/16325/1
--
To view, visit http://gerrit.cloudera.org:8080/16325
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I035708d627d42deb89bb34423b150bf9567d0f22
Gerrit-Change-Number: 16325
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-10066: Ugly hotfix for subtle bug in Pexpect
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16325 )
Change subject: IMPALA-10066: Ugly hotfix for subtle bug in Pexpect
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6265/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/16325
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I035708d627d42deb89bb34423b150bf9567d0f22
Gerrit-Change-Number: 16325
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Adam Tamas <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 11 Aug 2020 14:05:39 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10066: Ugly hotfix for subtle bug in Pexpect
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has abandoned this change. ( http://gerrit.cloudera.org:8080/16325 )
Change subject: IMPALA-10066: Ugly hotfix for subtle bug in Pexpect
......................................................................
Abandoned
Abandoned in favor of https://gerrit.cloudera.org/c/16322/
--
To view, visit http://gerrit.cloudera.org:8080/16325
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: I035708d627d42deb89bb34423b150bf9567d0f22
Gerrit-Change-Number: 16325
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Adam Tamas <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-10066: Ugly hotfix for subtle bug in Pexpect
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16325 )
Change subject: IMPALA-10066: Ugly hotfix for subtle bug in Pexpect
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/6877/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/16325
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I035708d627d42deb89bb34423b150bf9567d0f22
Gerrit-Change-Number: 16325
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Adam Tamas <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 11 Aug 2020 14:20:17 +0000
Gerrit-HasComments: No