[GitHub] [hive] deniskuzZ commented on a diff in pull request #3223: HIVE-26155: Create a new connection pool for compaction

[GitBox <gi...@apache.org>]

deniskuzZ commented on code in PR #3223:
URL: https://github.com/apache/hive/pull/3223#discussion_r855946205


##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/datasource/HikariCPDataSourceProvider.java:
##########
@@ -45,15 +45,19 @@ public class HikariCPDataSourceProvider implements DataSourceProvider {
 
   @Override
   public DataSource create(Configuration hdpConfig) throws SQLException {
+    int maxPoolSize = MetastoreConf.getIntVar(hdpConfig,

Review Comment:
   Could we extract this into the default method in the interface since we always use the same conf - MetastoreConf.ConfVars.CONNECTION_POOLING_MAX_CONNECTIONS?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org