You are viewing a plain text version of this content. The canonical link for it is here.

Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2020/02/10 19:21:36 UTC

[GitHub] [activemq-artemis] tabish121 commented on a change in pull request #2975: ARTEMIS-2617 Improve AMQP Journal loading

tabish121 commented on a change in pull request #2975: ARTEMIS-2617 Improve AMQP Journal loading
URL: https://github.com/apache/activemq-artemis/pull/2975#discussion_r377264879
 
 

 ##########
 File path: artemis-protocols/artemis-amqp-protocol/src/test/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPMessageTest.java
 ##########
 @@ -156,6 +157,72 @@ public void testCreateMessageForPersistenceDataReload() throws ActiveMQException
       assertEquals(TEST_TO_ADDRESS, message.getAddress());
    }
 
+   @Test
 
 Review comment:
   The tests seem a bit simplistic for such a change, what about annotations sections with many different annotations or annotations that don't match what you are looking for or are very very close but not quite what you are looking for etc.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services