[GitHub] [pulsar] michaeljmarshall commented on a diff in pull request #20297: [fix][fn] Correct TLS cert config translation from broker to fn worker

["michaeljmarshall (via GitHub)" <gi...@apache.org>]

michaeljmarshall commented on code in PR #20297:
URL: https://github.com/apache/pulsar/pull/20297#discussion_r1191356879


##########
pulsar-broker/src/test/java/org/apache/pulsar/functions/worker/PulsarFunctionTlsTest.java:
##########
@@ -233,6 +240,11 @@ public void testFunctionsCreation() throws Exception {
                 functionConfig, jarFilePathUrl
             );
 
+            // Function creation is not strongly consistent, so this test can fail with a get that is too eager and
+            // does not have retries.
+            final PulsarAdmin admin = pulsarAdmins[i];
+            Awaitility.await().untilAsserted(() -> admin.functions().getFunction(testTenant, "my-ns", functionName));

Review Comment:
   I didn't realize it worked that way. The test started passing after I added this block, so I incorrectly assumed it was right. Thanks!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org