You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/05/07 06:07:02 UTC

[GitHub] [apisix-dashboard] liuxiran opened a new pull request #1855: fix: default cors plugin formdata validation error

liuxiran opened a new pull request #1855:
URL: https://github.com/apache/apisix-dashboard/pull/1855


   Please answer these questions before submitting a pull request, **or your PR will get closed**.
   
   **Why submit this pull request?**
   
   - [X] Bugfix
   - [ ] New feature provided
   - [ ] Improve performance
   - [ ] Backport patches
   
   **What changes will this PR take into?**
   
   when I submitted default cors plugin configure in form mode, a validation error occured:
   
   ![2021-05-07 13-40-50屏幕截图](https://user-images.githubusercontent.com/2561857/117403225-6d33b000-af3a-11eb-99f2-6deb59cd432e.png)
   
   the error shows that `allow_origins_by_regex` should have at least 1 character.
   
   *  Reason
   
   schema of `cors` plugin:
   ```json
   {
       "properties": {
           ...
   	"allow_origins_by_regex": {
   	    "description": "you can use regex to allow specific origins when no credentials,for example use [.*\\.test.com] to allow a.test.com and b.test.com",
   	    "items": {
   		 "maxLength": 4096,
   		 "minLength": 1,
   		 "type": "string"
   	    },
   	    "minItems": 1,
   	    "type": "array",
   	    "uniqueItems": true
   	},
       },
      "type": "object"
   }
   ```
   shows that `allow_origins_by_regex` is not a required item, but when it configured, it should be at least 1 character.
   
   the default post data is:
   ```json
   {
       "allow_credential": false
       "allow_headers": "*"
       "allow_methods": ["*"]
       "allow_origins": "*"
       "allow_origins_by_regex": [""]
       "expose_headers": "*"
       "max_age": 5
   }
   ```
   the mistake is ` "allow_origins_by_regex": [""]`, why the value is [""]? In order to make UI better to use, we set default `allow_origins_by_regex` empty to have one input box in the page.
   
   * How to fix
   omit `allow_origins_by_regex` when it is not configured
   
   **Checklist:**
   
   - [X] Did you explain what problem does this PR solve? Or what new features have been added?
   - [ ] Have you added corresponding test cases?
   - [ ] Have you modified the corresponding document?
   - [X] Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1855: fix: default cors plugin formdata validation error

Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1855:
URL: https://github.com/apache/apisix-dashboard/pull/1855#issuecomment-834094197


   Deploy preview for *apisix-dashboard* ready!
   
   Built with commit 81c1fd2ad32b853ee482459f988c869e44c2ccc5
   
   https://deploy-preview-1855--apisix-dashboard.netlify.app


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] iamayushdas commented on a change in pull request #1855: fix: default cors plugin formdata validation error

Posted by GitBox <gi...@apache.org>.
iamayushdas commented on a change in pull request #1855:
URL: https://github.com/apache/apisix-dashboard/pull/1855#discussion_r628144550



##########
File path: web/src/components/Plugin/PluginDetail.tsx
##########
@@ -121,6 +122,12 @@ const PluginDetail: React.FC<Props> = ({
     if (name === 'cors') {
       const formData = UIForm.getFieldsValue();
       const newMethods = formData.allow_methods.join(",");
+      const compactAllowRegex = compact(formData.allow_origins_by_regex);

Review comment:
       Yes yes




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #1855: fix: default cors plugin formdata validation error

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1855:
URL: https://github.com/apache/apisix-dashboard/pull/1855#issuecomment-834105011


   # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1855?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1855](https://codecov.io/gh/apache/apisix-dashboard/pull/1855?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bf445c8) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/b1e66a286a7fa0fd276bcd4bf1dee8a065947676?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b1e66a2) will **increase** coverage by `0.36%`.
   > The diff coverage is `100.00%`.
   
   > :exclamation: Current head bf445c8 differs from pull request most recent head 07b9a7c. Consider uploading reports for the commit 07b9a7c to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/apisix-dashboard/pull/1855/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/apisix-dashboard/pull/1855?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #1855      +/-   ##
   ==========================================
   + Coverage   72.10%   72.47%   +0.36%     
   ==========================================
     Files         125      125              
     Lines        2947     2950       +3     
     Branches      711      712       +1     
   ==========================================
   + Hits         2125     2138      +13     
   + Misses        822      812      -10     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | frontend-e2e-test | `72.47% <100.00%> (+0.36%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1855?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [web/src/components/Plugin/UI/cors.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1855/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9VSS9jb3JzLnRzeA==) | `86.95% <ø> (+21.73%)` | :arrow_up: |
   | [web/src/components/Plugin/PluginDetail.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1855/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9QbHVnaW5EZXRhaWwudHN4) | `65.75% <100.00%> (+2.81%)` | :arrow_up: |
   | [web/src/helpers.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1855/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9oZWxwZXJzLnRzeA==) | `72.13% <0.00%> (+3.27%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1855?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1855?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [b1e66a2...07b9a7c](https://codecov.io/gh/apache/apisix-dashboard/pull/1855?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1855: fix: default cors plugin formdata validation error

Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1855:
URL: https://github.com/apache/apisix-dashboard/pull/1855#issuecomment-834094197


   Deploy preview for *apisix-dashboard* ready!
   
   Built with commit 07b9a7c4776c8e72c413874e5f1277176b7b826a
   
   https://deploy-preview-1855--apisix-dashboard.netlify.app


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] liuxiran commented on a change in pull request #1855: fix: default cors plugin formdata validation error

Posted by GitBox <gi...@apache.org>.
liuxiran commented on a change in pull request #1855:
URL: https://github.com/apache/apisix-dashboard/pull/1855#discussion_r628650747



##########
File path: web/src/components/Plugin/PluginDetail.tsx
##########
@@ -121,6 +122,12 @@ const PluginDetail: React.FC<Props> = ({
     if (name === 'cors') {
       const formData = UIForm.getFieldsValue();
       const newMethods = formData.allow_methods.join(",");
+      const compactAllowRegex = compact(formData.allow_origins_by_regex);

Review comment:
       > Hi, we may add the test case for this case.
   
   ok, on the way




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] codecov-commenter commented on pull request #1855: fix: default cors plugin formdata validation error

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1855:
URL: https://github.com/apache/apisix-dashboard/pull/1855#issuecomment-834105011


   # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1855?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1855](https://codecov.io/gh/apache/apisix-dashboard/pull/1855?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c79ec81) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/d7e08cb1637e312ce11c9ce49fd3a42ed3cf8571?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d7e08cb) will **increase** coverage by `1.17%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/apisix-dashboard/pull/1855/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/apisix-dashboard/pull/1855?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #1855      +/-   ##
   ==========================================
   + Coverage   71.05%   72.23%   +1.17%     
   ==========================================
     Files         173      125      -48     
     Lines        6202     2950    -3252     
     Branches      710      712       +2     
   ==========================================
   - Hits         4407     2131    -2276     
   + Misses       1538      819     -719     
   + Partials      257        0     -257     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | backend-e2e-test | `?` | |
   | backend-e2e-test-ginkgo | `?` | |
   | backend-unit-test | `?` | |
   | frontend-e2e-test | `72.23% <100.00%> (+0.09%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1855?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [web/src/components/Plugin/PluginDetail.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1855/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9QbHVnaW5EZXRhaWwudHN4) | `65.75% <100.00%> (+2.81%)` | :arrow_up: |
   | [web/src/pages/Route/Create.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1855/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9DcmVhdGUudHN4) | `90.99% <100.00%> (+0.25%)` | :arrow_up: |
   | [web/src/helpers.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1855/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9oZWxwZXJzLnRzeA==) | `68.85% <0.00%> (-3.28%)` | :arrow_down: |
   | [api/internal/handler/label/label.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1855/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvbGFiZWwvbGFiZWwuZ28=) | | |
   | [api/internal/handler/schema/plugin.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1855/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2NoZW1hL3BsdWdpbi5nbw==) | | |
   | [api/internal/utils/pid.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1855/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL3BpZC5nbw==) | | |
   | [api/internal/core/store/store\_mock.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1855/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVfbW9jay5nbw==) | | |
   | [api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1855/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv) | | |
   | [api/internal/handler/consumer/consumer.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1855/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvY29uc3VtZXIvY29uc3VtZXIuZ28=) | | |
   | [api/internal/handler/tool/tool.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1855/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvdG9vbC90b29sLmdv) | | |
   | ... and [42 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1855/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1855?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1855?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [b1e66a2...c79ec81](https://codecov.io/gh/apache/apisix-dashboard/pull/1855?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] liuxiran commented on a change in pull request #1855: fix: default cors plugin formdata validation error

Posted by GitBox <gi...@apache.org>.
liuxiran commented on a change in pull request #1855:
URL: https://github.com/apache/apisix-dashboard/pull/1855#discussion_r628714443



##########
File path: web/src/components/Plugin/PluginDetail.tsx
##########
@@ -121,6 +122,12 @@ const PluginDetail: React.FC<Props> = ({
     if (name === 'cors') {
       const formData = UIForm.getFieldsValue();
       const newMethods = formData.allow_methods.join(",");
+      const compactAllowRegex = compact(formData.allow_origins_by_regex);

Review comment:
       fixed




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1855: fix: default cors plugin formdata validation error

Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1855:
URL: https://github.com/apache/apisix-dashboard/pull/1855#issuecomment-834094197


   Deploy preview for *apisix-dashboard* processing.
   
   Building with commit 81c1fd2ad32b853ee482459f988c869e44c2ccc5
   
   https://app.netlify.com/sites/apisix-dashboard/deploys/609623971258930008d3fd58


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1855: fix: default cors plugin formdata validation error

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #1855:
URL: https://github.com/apache/apisix-dashboard/pull/1855#discussion_r628142920



##########
File path: web/src/components/Plugin/PluginDetail.tsx
##########
@@ -121,6 +122,12 @@ const PluginDetail: React.FC<Props> = ({
     if (name === 'cors') {
       const formData = UIForm.getFieldsValue();
       const newMethods = formData.allow_methods.join(",");
+      const compactAllowRegex = compact(formData.allow_origins_by_regex);

Review comment:
       Hi, we may add the test case for this case.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] imjoey merged pull request #1855: fix: default cors plugin formdata validation error

Posted by GitBox <gi...@apache.org>.
imjoey merged pull request #1855:
URL: https://github.com/apache/apisix-dashboard/pull/1855


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1855: fix: default cors plugin formdata validation error

Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1855:
URL: https://github.com/apache/apisix-dashboard/pull/1855#issuecomment-834094197


   Deploy preview for *apisix-dashboard* processing.
   
   Building with commit 07b9a7c4776c8e72c413874e5f1277176b7b826a
   
   https://app.netlify.com/sites/apisix-dashboard/deploys/60962ad0d04faa0007181487


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1855: fix: default cors plugin formdata validation error

Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1855:
URL: https://github.com/apache/apisix-dashboard/pull/1855#issuecomment-834094197


   Deploy preview for *apisix-dashboard* ready!
   
   Built with commit c79ec8148ad7936b93731ca720acccd52428a5a1
   
   https://deploy-preview-1855--apisix-dashboard.netlify.app


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] netlify[bot] commented on pull request #1855: fix: default cors plugin formdata validation error

Posted by GitBox <gi...@apache.org>.
netlify[bot] commented on pull request #1855:
URL: https://github.com/apache/apisix-dashboard/pull/1855#issuecomment-834094197


   Deploy preview for *apisix-dashboard* processing.
   
   Building with commit c79ec8148ad7936b93731ca720acccd52428a5a1
   
   https://app.netlify.com/sites/apisix-dashboard/deploys/6094d8f7599ff900085b6667


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org