[GitHub] [trafficserver] ywkaras commented on a diff in pull request #9074: Updates to origin side ALPN configuration implementation

[GitBox <gi...@apache.org>]

ywkaras commented on code in PR #9074:
URL: https://github.com/apache/trafficserver/pull/9074#discussion_r960833453


##########
include/records/I_RecHttp.h:
##########
@@ -542,5 +542,9 @@ extern void ts_session_protocol_well_known_name_indices_init();
  * @return True if the conversion was successful, false otherwise. Note that
  * the wire format does not support an empty protocol list, therefore this
  * function returns false if @a protocols is an empty string.
+ *
+ * TODO: ideally this would take a ts::TextView for @a protocols, but currently
+ * ts::TextView does not have a char* constructor while std::string_view does.
+ * Once that is added, this can be seemlessly switched to a ts::TextView.

Review Comment:
   You can use:
   ```
   TextView tv{std::string_view{c_str}};
   ```
   or
   ```
   TextView tv{c_str, std::strlen(c_str)};
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org