You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/01/30 15:21:58 UTC
[GitHub] srowen commented on issue #23673: [SPARK-26751][SQL] Fix memory
leak when statement run in background and throw exception which is not
HiveSQLException
srowen commented on issue #23673: [SPARK-26751][SQL] Fix memory leak when statement run in background and throw exception which is not HiveSQLException
URL: https://github.com/apache/spark/pull/23673#issuecomment-458983498
I don't know this part well, but that seems reasonable for consistency with how the exception is handled above it, and the reasons you give. The Hive code that executes this does appear to expect a HiveSQLException, certainly in a non-fatal case. I guess that code could be expanded to catch all exceptions and clean up in all cases, but that is code we copied from Hive right? so maybe best to not modify it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org