You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by "dcapwell (via GitHub)" <gi...@apache.org> on 2026/05/22 19:39:55 UTC
[PR] CASSANDRA-21398: Add agent skills for property / stateful testing [cassandra]
dcapwell opened a new pull request, #4837:
URL: https://github.com/apache/cassandra/pull/4837
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] CASSANDRA-21398: Add agent skills for property / stateful testing [cassandra]
Posted by "dcapwell (via GitHub)" <gi...@apache.org>.
dcapwell commented on code in PR #4837:
URL: https://github.com/apache/cassandra/pull/4837#discussion_r3290987913
##########
src/java/org/apache/cassandra/utils/Hex.java:
##########
@@ -106,7 +106,12 @@ public static long parseLong(String hex, int start, int end)
for (int i = start ; i < end ; ++i)
{
char c = hex.charAt(i);
- result |= (long)(c - (c >= 'a' ? 'a' - 10 : '0')) << shift;
Review Comment:
hex includes upper case but this method doesn't handle that. This is fine in existing usage as we use `Long.toHexString(lsb);` which explicitly documents that its lower case only (if you want upper case it says to do `toUpperCase`).
So this bug fix isn't for any existing logic, but more defensive to make sure future logic works correctly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] CASSANDRA-21398: Add agent skills for property / stateful testing [cassandra]
Posted by "dcapwell (via GitHub)" <gi...@apache.org>.
dcapwell commented on code in PR #4837:
URL: https://github.com/apache/cassandra/pull/4837#discussion_r3290870662
##########
test/unit/org/apache/cassandra/utils/AccordGenerators.java:
##########
@@ -111,6 +111,32 @@ private AccordGenerators()
{
}
+ /**
+ * Generates a random byte array whose size is determined by the given size generator.
+ * Fills 8 bytes at a time using {@code nextLong()} for efficiency, then fills any remaining bytes individually.
+ */
+ public static Gen<byte[]> byteArray(Gen.IntGen sizeGen)
Review Comment:
didn't have a good place to put this... i really need to get rid of QuickTheories...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org