You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@samza.apache.org by xi...@apache.org on 2018/01/09 01:26:01 UTC

[20/33] samza-hello-samza git commit: SAMZA-1236: Minor refinements to the high level API tutorial

SAMZA-1236: Minor refinements to the high level API tutorial

Author: Jacob Maes <jm...@linkedin.com>

Reviewers: Bharath Kumarasubramanian <bk...@linkedin.com>

Closes #15 from jmakes/samza-1236-2


Project: http://git-wip-us.apache.org/repos/asf/samza-hello-samza/repo
Commit: http://git-wip-us.apache.org/repos/asf/samza-hello-samza/commit/28af952d
Tree: http://git-wip-us.apache.org/repos/asf/samza-hello-samza/tree/28af952d
Diff: http://git-wip-us.apache.org/repos/asf/samza-hello-samza/diff/28af952d

Branch: refs/heads/master
Commit: 28af952d5430cb029b168fd360c844da8f9a60b4
Parents: 01fb456
Author: Jacob Maes <jm...@linkedin.com>
Authored: Thu May 18 12:28:13 2017 -0700
Committer: Jacob Maes <jm...@linkedin.com>
Committed: Thu May 18 12:28:13 2017 -0700

----------------------------------------------------------------------
 .../config/wikipedia-application.properties     | 24 ++++++++------------
 .../application/WikipediaApplication.java       | 11 ++++++---
 2 files changed, 18 insertions(+), 17 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/samza-hello-samza/blob/28af952d/src/main/config/wikipedia-application.properties
----------------------------------------------------------------------
diff --git a/src/main/config/wikipedia-application.properties b/src/main/config/wikipedia-application.properties
index 59a124f..aeb8069 100644
--- a/src/main/config/wikipedia-application.properties
+++ b/src/main/config/wikipedia-application.properties
@@ -15,23 +15,17 @@
 # specific language governing permissions and limitations
 # under the License.
 
-# Job
+# Application / Job
+app.class=samza.examples.wikipedia.application.WikipediaApplication
+app.runner.class=org.apache.samza.runtime.RemoteApplicationRunner
+
 job.factory.class=org.apache.samza.job.yarn.YarnJobFactory
 job.name=wikipedia-application
+job.default.system=kafka
 
 # YARN
 yarn.package.path=file://${basedir}/target/${project.artifactId}-${pom.version}-dist.tar.gz
 
-# Task/Application
-app.runner.class=org.apache.samza.runtime.RemoteApplicationRunner
-app.class=samza.examples.wikipedia.application.WikipediaApplication
-task.window.ms=10000
-
-# Serializers
-serializers.registry.json.class=org.apache.samza.serializers.JsonSerdeFactory
-serializers.registry.string.class=org.apache.samza.serializers.StringSerdeFactory
-serializers.registry.integer.class=org.apache.samza.serializers.IntegerSerdeFactory
-
 # Wikipedia System
 systems.wikipedia.samza.factory=samza.examples.wikipedia.system.WikipediaSystemFactory
 systems.wikipedia.host=irc.wikimedia.org
@@ -44,6 +38,11 @@ systems.kafka.producer.bootstrap.servers=localhost:9092
 systems.kafka.default.stream.replication.factor=1
 systems.kafka.default.stream.samza.msg.serde=json
 
+# Serializers
+serializers.registry.json.class=org.apache.samza.serializers.JsonSerdeFactory
+serializers.registry.string.class=org.apache.samza.serializers.StringSerdeFactory
+serializers.registry.integer.class=org.apache.samza.serializers.IntegerSerdeFactory
+
 # Streams which are not on default system or have special characters in the physical name.
 streams.en-wikipedia.samza.system=wikipedia
 streams.en-wikipedia.samza.physical.name=#en.wikipedia
@@ -60,9 +59,6 @@ stores.wikipedia-stats.changelog=kafka.wikipedia-stats-changelog
 stores.wikipedia-stats.key.serde=string
 stores.wikipedia-stats.msg.serde=integer
 
-# Defaults
-job.default.system=kafka
-
 # Metrics
 metrics.reporters=snapshot,jmx
 metrics.reporter.snapshot.class=org.apache.samza.metrics.reporter.MetricsSnapshotReporterFactory

http://git-wip-us.apache.org/repos/asf/samza-hello-samza/blob/28af952d/src/main/java/samza/examples/wikipedia/application/WikipediaApplication.java
----------------------------------------------------------------------
diff --git a/src/main/java/samza/examples/wikipedia/application/WikipediaApplication.java b/src/main/java/samza/examples/wikipedia/application/WikipediaApplication.java
index 3432e3d..c320209 100644
--- a/src/main/java/samza/examples/wikipedia/application/WikipediaApplication.java
+++ b/src/main/java/samza/examples/wikipedia/application/WikipediaApplication.java
@@ -66,15 +66,20 @@ import samza.examples.wikipedia.system.WikipediaFeed.WikipediaFeedEvent;
 public class WikipediaApplication implements StreamApplication {
   private static final Logger log = LoggerFactory.getLogger(WikipediaApplication.class);
 
-  private static final String STATS_STORE_NAME = "wikipedia-stats";
-  private static final String EDIT_COUNT_KEY = "count-edits-all-time";
-
+  // Inputs
   private static final String WIKIPEDIA_STREAM_ID = "en-wikipedia";
   private static final String WIKTIONARY_STREAM_ID = "en-wiktionary";
   private static final String WIKINEWS_STREAM_ID = "en-wikinews";
 
+  // Outputs
   private static final String STATS_STREAM_ID = "wikipedia-stats";
 
+  // Stores
+  private static final String STATS_STORE_NAME = "wikipedia-stats";
+
+  // Metrics
+  private static final String EDIT_COUNT_KEY = "count-edits-all-time";
+
   @Override
   public void init(StreamGraph graph, Config config) {
     // Inputs