Re: [I] Validator ergonomics for consumer repos: validate CLI exits 0 on stub, validate.py takes one file, default schema path assumes repo layout [ossie]

["ihadoop (via GitHub)" <gi...@apache.org>]

ihadoop commented on issue #266:
URL: https://github.com/apache/ossie/issues/266#issuecomment-6097529266

   All three items appear landed on current `main` (642cb89) — re-checked each, so noting it for triage:
   
   **1. `ossie validate` exiting 0 on a stub** — closed by #390. `cli/cmd/validate.go` is now `return fmt.Errorf("%s is not yet implemented", cmd.CommandPath())`, so the command exits non-zero instead of printing a line and passing. `convert` and the two `plugin` mutators took the same treatment.
   
   **2. one file per run** — closed by #545. Verified:
   
   ```
   $ python validation/validate.py model_a.yaml model_b.yaml
   == from_gooddata.yaml
   Validation PASSED: from_gooddata.yaml
   
   2 of 2 file(s) passed
   ```
   
   The aggregate summary the issue asked for is there, so a consumer repo no longer needs the Makefile loop that collects exit codes by hand.
   
   **3. default schema path assuming the upstream layout** — closed by #545. `resolve_schema_path()` prefers `OSSIE_SCHEMA` when set, and the not-found diagnostic now ends with `Pass --schema <schema_file> or set OSSIE_SCHEMA to point at ossie-schema.json.` — which is the `--schema` hint the issue suggested, instead of pointing at a path nobody chose. The module docstring documents the vendored case too.
   
   One thing I cannot answer from the code, because it is the design question the issue raises at the end: whether the Go CLI is expected to absorb this validator's job eventually. If it is, item 2 and 3 may be worth less than they look; if not, this issue can probably be closed. cc @kayemkim @cskwork since the September thread here was about who would take it.
   
   Not my call to close.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ossie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org