You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@samoa.apache.org by Corey Sterling <co...@gmail.com> on 2019/12/02 20:01:40 UTC

[VOTE] Release SAMOA 0.5.0 (incubating) RC0

Hi all,

Please vote on releasing the following release candidate as Apache SAMOA
(incubating) version 0.5.0.

This release will be the third release for SAMOA in the incubator.

-------------------------------------------------------------
The commit to be voted on is in the branch "releases/0.5.0-incubating-RC0"
(commit c05a013a2d6ff49a978f15bc6bf6a520e95aa5d8):
https://git-wip-us.apache.org/repos/asf?p=incubator-samoa.git;a=commit;h=c05a013a2d6ff49a978f15bc6bf6a520e95aa5d8

Tag v0.5.0-incubating:
https://git-wip-us.apache.org/repos/asf?p=incubator-samoa.git;a=commit;h=40799327b7e01508eddeece410f714cca768c83e

Release artifacts are signed with the following key:
https://keyserver.ubuntu.com/pks/lookup?op=get&search=0xa7dd4e2d20a5b5f2828fc0131b443a1d6541e300
(sorry this is not the Apache people page but it didn't update for some
reason)

The staging repository for this release can be found at:
https://repository.apache.org/content/repositories/staging/org/apache/samoa/samoa/0.5.0-incubating/

The developer's version artifacts:
https://dist.apache.org/repos/dist/dev/incubator/samoa/0.5.0-incubating-rc0/

-------------------------------------------------------------

Please vote on releasing this package as Apache SAMOA 0.5.0 (incubating).

The vote is open for the next 72 hours and passes if a majority of at least
three +1 PPMC votes are cast.

[ ] +1 Release this package as Apache SAMOA 0.5.0 (incubating)
[ ] -1 Do not release this package because ...

I'm +1 (non-binding) on the release.

Cheers,

Corey.

Re: [VOTE] Release SAMOA 0.5.0 (incubating) RC0

Posted by Justin Mclean <jm...@apache.org>.

HI,

> I am working on updating the licencing in the files now. It seems to me that the previous 2 releases under Apache incubation used the licences as they stand - has Apache's licencing guidelines changed recently? Or was this an oversight?

Well I did point this out last release [1], but had forgotten about that and rediscovered the same issue. If an issue is pointed out in a release you should fix before the next release.


> Does Apache recommend a standard way for automating the licence checking process?

I would use rat, but it may not pick up an issue like this. In my experience automation will only pick up most issues not all issues. We would need to make many changes for license header and licenses and notice files to be machine friendly.

Thanks,
Justin

1. https://lists.apache.org/thread.html/f74288b1a6b644f9359b89632bcd9911c6aa14d4a52cbb64ab553481%40%3Cgeneral.incubator.apache.org%3E

Re: [VOTE] Release SAMOA 0.5.0 (incubating) RC0

Posted by Corey Sterling <co...@gmail.com>.

Hi Justin,

Thanks for taking the time to review the release candidate.

I am working on updating the licencing in the files now. It seems to me
that the previous 2 releases under Apache incubation used the licences as
they stand - has Apache's licencing guidelines changed recently? Or was
this an oversight?

I have contacted Łukasz Ławniczak and received his permission to remove the
copyright from the files where he is named.

Does Apache recommend a standard way for automating the licence
checking process? SAMOA currently uses the licence-maven-plugin but I am
thinking of moving to maven-checkstyle-plugin as it is more flexible in
checking the licence and can also support code-style checks. But if Apache
already has some configuration for this, that would be preferable.

Thanks,

Corey.

On Tue, Dec 3, 2019 at 10:02 AM Justin Mclean <jm...@apache.org> wrote:

> Hi,
>
> I took a quick look at the release and I would probably be -1 on it if
> this come up for an IPMC vote as you are not using the standard ASF header
> on your source files. The standard header for ASF projects doesn't include
> a copyright line. I also see some files copyright Łukasz Ławniczak, who is
> not mentioned in LICENSE and that NOTICE is incorrect that it mentions
> bundled software that should be listed in LICENSE.
>
> Thanks,
> Justin
>

Re: [VOTE] Release SAMOA 0.5.0 (incubating) RC0

Posted by Justin Mclean <jm...@apache.org>.

Hi,

I took a quick look at the release and I would probably be -1 on it if this come up for an IPMC vote as you are not using the standard ASF header on your source files. The standard header for ASF projects doesn't include a copyright line. I also see some files copyright Łukasz Ławniczak, who is not mentioned in LICENSE and that NOTICE is incorrect that it mentions bundled software that should be listed in LICENSE.

Thanks,
Justin