You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/08/15 05:07:36 UTC

[GitHub] [shardingsphere] jacksparrow414 opened a new pull request #6857: add test cases for SQLToken

jacksparrow414 opened a new pull request #6857:
URL: https://github.com/apache/shardingsphere/pull/6857


   * Add test case for RemoveToken.toString()
   
   * Add test case for SubstitutableColumnNameToken.toString()
   
   * Add test case for UseDefaultInsertColumnsToken.toString()
   
   Fixes #6782 .
   
   Changes proposed in this pull request:
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] coveralls edited a comment on pull request #6857: add test cases for SQLToken

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #6857:
URL: https://github.com/apache/shardingsphere/pull/6857#issuecomment-675210873


   ## Pull Request Test Coverage Report for [Build 13791](https://coveralls.io/builds/32775139)
   
   * **0** of **0**   changed or added relevant lines in **0** files are covered.
   * No unchanged relevant lines lost coverage.
   * Overall coverage increased (+**0.06%**) to **58.264%**
   
   ---
   
   
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/32775139/badge)](https://coveralls.io/builds/32775139) |
   | :-- | --: |
   | Change from base [Build 13788](https://coveralls.io/builds/32774477): |  0.06% |
   | Covered Lines: | 13170 |
   | Relevant Lines: | 22604 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] coveralls commented on pull request #6857: add test cases for SQLToken

Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #6857:
URL: https://github.com/apache/shardingsphere/pull/6857#issuecomment-675210873


   ## Pull Request Test Coverage Report for [Build 13789](https://coveralls.io/builds/32774874)
   
   * **0** of **0**   changed or added relevant lines in **0** files are covered.
   * No unchanged relevant lines lost coverage.
   * Overall coverage increased (+**0.06%**) to **58.264%**
   
   ---
   
   
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/32774874/badge)](https://coveralls.io/builds/32774874) |
   | :-- | --: |
   | Change from base [Build 13788](https://coveralls.io/builds/32774477): |  0.06% |
   | Covered Lines: | 13170 |
   | Relevant Lines: | 22604 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] terrymanu merged pull request #6857: add test cases for SQLToken

Posted by GitBox <gi...@apache.org>.
terrymanu merged pull request #6857:
URL: https://github.com/apache/shardingsphere/pull/6857


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] codecov-commenter commented on pull request #6857: add test cases for SQLToken

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #6857:
URL: https://github.com/apache/shardingsphere/pull/6857#issuecomment-674352396


   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/6857?src=pr&el=h1) Report
   > Merging [#6857](https://codecov.io/gh/apache/shardingsphere/pull/6857?src=pr&el=desc) into [master](https://codecov.io/gh/apache/shardingsphere/commit/3a2c21414195d70de3a1adaa2f086959333a0cd4&el=desc) will **increase** coverage by `0.23%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere/pull/6857/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so)](https://codecov.io/gh/apache/shardingsphere/pull/6857?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6857      +/-   ##
   ============================================
   + Coverage     55.98%   56.21%   +0.23%     
   - Complexity      437      440       +3     
   ============================================
     Files          1242     1243       +1     
     Lines         22001    22005       +4     
     Branches       3952     3952              
   ============================================
   + Hits          12318    12371      +53     
   + Misses         8900     8848      -52     
   - Partials        783      786       +3     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/6857?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [.../metrics/facade/handler/MetricsTrackerHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/6857/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtY29udHJvbC1wYW5lbC9zaGFyZGluZ3NwaGVyZS1tZXRyaWNzL3NoYXJkaW5nc3BoZXJlLW1ldHJpY3MtZmFjYWRlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9tZXRyaWNzL2ZhY2FkZS9oYW5kbGVyL01ldHJpY3NUcmFja2VySGFuZGxlci5qYXZh) | `91.22% <0.00%> (-1.76%)` | `1.00% <0.00%> (ø%)` | |
   | [...ingsphere/sql/parser/core/visitor/VisitorRule.java](https://codecov.io/gh/apache/shardingsphere/pull/6857/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9jb3JlL3Zpc2l0b3IvVmlzaXRvclJ1bGUuamF2YQ==) | `100.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
   | [...sql/parser/mysql/visitor/impl/MySQLDDLVisitor.java](https://codecov.io/gh/apache/shardingsphere/pull/6857/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWRpYWxlY3Qvc2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci1teXNxbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9teXNxbC92aXNpdG9yL2ltcGwvTXlTUUxERExWaXNpdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
   | [...rser/sql/statement/ddl/AlterDatabaseStatement.java](https://codecov.io/gh/apache/shardingsphere/pull/6857/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXN0YXRlbWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvc3RhdGVtZW50L2RkbC9BbHRlckRhdGFiYXNlU3RhdGVtZW50LmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
   | [...ule/EncryptColumnRuleConfigurationYamlSwapper.java](https://codecov.io/gh/apache/shardingsphere/pull/6857/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtZW5jcnlwdC9zaGFyZGluZ3NwaGVyZS1lbmNyeXB0LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZW5jcnlwdC95YW1sL3N3YXBwZXIvcnVsZS9FbmNyeXB0Q29sdW1uUnVsZUNvbmZpZ3VyYXRpb25ZYW1sU3dhcHBlci5qYXZh) | `11.11% <0.00%> (+11.11%)` | `0.00% <0.00%> (ø%)` | |
   | [...RuleAlgorithmProviderConfigurationYamlSwapper.java](https://codecov.io/gh/apache/shardingsphere/pull/6857/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtZW5jcnlwdC9zaGFyZGluZ3NwaGVyZS1lbmNyeXB0LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZW5jcnlwdC95YW1sL3N3YXBwZXIvRW5jcnlwdFJ1bGVBbGdvcml0aG1Qcm92aWRlckNvbmZpZ3VyYXRpb25ZYW1sU3dhcHBlci5qYXZh) | `21.05% <0.00%> (+21.05%)` | `0.00% <0.00%> (ø%)` | |
   | [...rule/EncryptTableRuleConfigurationYamlSwapper.java](https://codecov.io/gh/apache/shardingsphere/pull/6857/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtZW5jcnlwdC9zaGFyZGluZ3NwaGVyZS1lbmNyeXB0LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZW5jcnlwdC95YW1sL3N3YXBwZXIvcnVsZS9FbmNyeXB0VGFibGVSdWxlQ29uZmlndXJhdGlvbllhbWxTd2FwcGVyLmphdmE=) | `42.85% <0.00%> (+42.85%)` | `0.00% <0.00%> (ø%)` | |
   | [...rypt/yaml/config/YamlEncryptRuleConfiguration.java](https://codecov.io/gh/apache/shardingsphere/pull/6857/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtZW5jcnlwdC9zaGFyZGluZ3NwaGVyZS1lbmNyeXB0LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZW5jcnlwdC95YW1sL2NvbmZpZy9ZYW1sRW5jcnlwdFJ1bGVDb25maWd1cmF0aW9uLmphdmE=) | `75.00% <0.00%> (+75.00%)` | `0.00% <0.00%> (ø%)` | |
   | [...l/swapper/EncryptRuleConfigurationYamlSwapper.java](https://codecov.io/gh/apache/shardingsphere/pull/6857/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtZW5jcnlwdC9zaGFyZGluZ3NwaGVyZS1lbmNyeXB0LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZW5jcnlwdC95YW1sL3N3YXBwZXIvRW5jcnlwdFJ1bGVDb25maWd1cmF0aW9uWWFtbFN3YXBwZXIuamF2YQ==) | `95.65% <0.00%> (+95.65%)` | `0.00% <0.00%> (ø%)` | |
   | [...ra/rewrite/sql/token/pojo/generic/RemoveToken.java](https://codecov.io/gh/apache/shardingsphere/pull/6857/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtcmV3cml0ZS9zaGFyZGluZ3NwaGVyZS1pbmZyYS1yZXdyaXRlLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvaW5mcmEvcmV3cml0ZS9zcWwvdG9rZW4vcG9qby9nZW5lcmljL1JlbW92ZVRva2VuLmphdmE=) | `100.00% <0.00%> (+100.00%)` | `1.00% <0.00%> (+1.00%)` | |
   | ... and [3 more](https://codecov.io/gh/apache/shardingsphere/pull/6857/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/6857?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/6857?src=pr&el=footer). Last update [3a2c214...83f5d52](https://codecov.io/gh/apache/shardingsphere/pull/6857?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] codecov-commenter edited a comment on pull request #6857: add test cases for SQLToken

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #6857:
URL: https://github.com/apache/shardingsphere/pull/6857#issuecomment-674352396


   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/6857?src=pr&el=h1) Report
   > Merging [#6857](https://codecov.io/gh/apache/shardingsphere/pull/6857?src=pr&el=desc) into [master](https://codecov.io/gh/apache/shardingsphere/commit/5b3c9ff145cf5a8b97ad32b9e94b57086c0087c7&el=desc) will **increase** coverage by `0.05%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere/pull/6857/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so)](https://codecov.io/gh/apache/shardingsphere/pull/6857?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6857      +/-   ##
   ============================================
   + Coverage     56.16%   56.22%   +0.05%     
   - Complexity      437      440       +3     
   ============================================
     Files          1243     1243              
     Lines         22005    22005              
     Branches       3952     3952              
   ============================================
   + Hits          12359    12372      +13     
   + Misses         8861     8848      -13     
     Partials        785      785              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/6857?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...ra/rewrite/sql/token/pojo/generic/RemoveToken.java](https://codecov.io/gh/apache/shardingsphere/pull/6857/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtcmV3cml0ZS9zaGFyZGluZ3NwaGVyZS1pbmZyYS1yZXdyaXRlLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvaW5mcmEvcmV3cml0ZS9zcWwvdG9rZW4vcG9qby9nZW5lcmljL1JlbW92ZVRva2VuLmphdmE=) | `100.00% <0.00%> (+100.00%)` | `1.00% <0.00%> (+1.00%)` | |
   | [...ken/pojo/generic/SubstitutableColumnNameToken.java](https://codecov.io/gh/apache/shardingsphere/pull/6857/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtcmV3cml0ZS9zaGFyZGluZ3NwaGVyZS1pbmZyYS1yZXdyaXRlLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvaW5mcmEvcmV3cml0ZS9zcWwvdG9rZW4vcG9qby9nZW5lcmljL1N1YnN0aXR1dGFibGVDb2x1bW5OYW1lVG9rZW4uamF2YQ==) | `100.00% <0.00%> (+100.00%)` | `1.00% <0.00%> (+1.00%)` | |
   | [...ken/pojo/generic/UseDefaultInsertColumnsToken.java](https://codecov.io/gh/apache/shardingsphere/pull/6857/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtcmV3cml0ZS9zaGFyZGluZ3NwaGVyZS1pbmZyYS1yZXdyaXRlLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvaW5mcmEvcmV3cml0ZS9zcWwvdG9rZW4vcG9qby9nZW5lcmljL1VzZURlZmF1bHRJbnNlcnRDb2x1bW5zVG9rZW4uamF2YQ==) | `100.00% <0.00%> (+100.00%)` | `1.00% <0.00%> (+1.00%)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/6857?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/6857?src=pr&el=footer). Last update [5b3c9ff...414e244](https://codecov.io/gh/apache/shardingsphere/pull/6857?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org