You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@allura.apache.org by br...@apache.org on 2026/05/29 16:17:19 UTC

(allura) 02/02: fixup! [#8607] move |safe to be directly on the string source

This is an automated email from the ASF dual-hosted git repository.

asf-gitbox-commits pushed a commit to branch db/8607
in repository https://gitbox.apache.org/repos/asf/allura.git

commit 68a41a19501dda105518de5f80e19e35d9e8668e
Author: Dave Brondsema <da...@brondsema.net>
AuthorDate: Fri May 29 12:17:04 2026 -0400

    fixup! [#8607] move |safe to be directly on the string source
---
 Allura/allura/ext/admin/templates/project_admin.html | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/Allura/allura/ext/admin/templates/project_admin.html b/Allura/allura/ext/admin/templates/project_admin.html
index ba3e45b7f..a850d9df5 100644
--- a/Allura/allura/ext/admin/templates/project_admin.html
+++ b/Allura/allura/ext/admin/templates/project_admin.html
@@ -121,6 +121,12 @@
 {% block extra_js %}
 <script>
 $(function() {
+    {# need to escape HTML fields that hopscotch will interpret.  This makes our |safe usage above be correct, and non-safe will get escaped.
+      End result is the hopscotch tooltips match the main content output (either escaped or allowed html) #}
+    {% for s in tour.steps %}
+      {% do s.update({'title': s.title|escape}) %}
+      {% do s.update({'content': s.content|escape}) %}
+    {% endfor %}
     var tour = {{ tour|tojson }};
     tour.onError = function() {
         var step = hopscotch.getCurrStepNum();