You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Jiang Yan Xu <ya...@jxu.me> on 2014/05/29 23:17:46 UTC

Review Request 22054: Fixed MESOS-1427: 'friend' statement in Variable resolved to a different State class on clang 3.2

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22054/
-----------------------------------------------------------

Review request for mesos, Benjamin Hindman and Dominic Hamon.


Bugs: MESOS-1427
    https://issues.apache.org/jira/browse/MESOS-1427


Repository: mesos-git


Description
-------

See summary.


Diffs
-----

  src/state/protobuf.hpp 802617b48586d8fc682d5efda3e2b86205e988b6 

Diff: https://reviews.apache.org/r/22054/diff/


Testing
-------

make check on clang 3.2


Thanks,

Jiang Yan Xu


Re: Review Request 22054: Fixed MESOS-1427: 'friend' statement in Variable resolved to a different State class on clang 3.2

Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22054/#review44294
-----------------------------------------------------------

Ship it!


Ship It!

- Dominic Hamon


On May 29, 2014, 2:17 p.m., Jiang Yan Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22054/
> -----------------------------------------------------------
> 
> (Updated May 29, 2014, 2:17 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Dominic Hamon.
> 
> 
> Bugs: MESOS-1427
>     https://issues.apache.org/jira/browse/MESOS-1427
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/state/protobuf.hpp 802617b48586d8fc682d5efda3e2b86205e988b6 
> 
> Diff: https://reviews.apache.org/r/22054/diff/
> 
> 
> Testing
> -------
> 
> make check on clang 3.2
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>


Re: Review Request 22054: Fixed MESOS-1427: 'friend' statement in Variable resolved to a different State class on clang 3.2

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22054/#review44303
-----------------------------------------------------------

Ship it!


Ship It!

- Vinod Kone


On May 29, 2014, 9:17 p.m., Jiang Yan Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22054/
> -----------------------------------------------------------
> 
> (Updated May 29, 2014, 9:17 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Dominic Hamon.
> 
> 
> Bugs: MESOS-1427
>     https://issues.apache.org/jira/browse/MESOS-1427
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/state/protobuf.hpp 802617b48586d8fc682d5efda3e2b86205e988b6 
> 
> Diff: https://reviews.apache.org/r/22054/diff/
> 
> 
> Testing
> -------
> 
> make check on clang 3.2
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>