[GitHub] [solr] asalamon74 commented on a change in pull request #135: SOLR-15421 ConfigSetService.checkConfigExists accepts empty configs

[GitBox <gi...@apache.org>]

asalamon74 commented on a change in pull request #135:
URL: https://github.com/apache/solr/pull/135#discussion_r642879790



##########
File path: solr/core/src/test/org/apache/solr/cloud/TestConfigSetsAPI.java
##########
@@ -1121,10 +1121,6 @@ public void testDeleteErrors() throws Exception {
     DeleteNoErrorChecking delete = new DeleteNoErrorChecking();
     verifyException(solrClient, delete, NAME);
 
-    // ConfigSet doesn't exist

Review comment:
       I removed the existence check from ConfigSetCmds.deleteConfigSet (as far as I understand, this was the suggestion here: https://issues.apache.org/jira/browse/SOLR-15421?focusedCommentId=17349401&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17349401 )
   
   After that this test fails because it expects a failure. So I changed the test. Removed this part, and add  a similar test to the end of testDelete.
   
   This means that this patch changes the behaviour of the delecteConfigSet commands. If this is bad, we can go back to the first version of this patch with two checkConfigExists methods.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org