You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Shai Erera (JIRA)" <ji...@apache.org> on 2015/03/25 22:04:53 UTC
[jira] [Commented] (SOLR-7298) Fix Collections API SolrJ calls to
not add name parameter when not needed
[ https://issues.apache.org/jira/browse/SOLR-7298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14380766#comment-14380766 ]
Shai Erera commented on SOLR-7298:
----------------------------------
Thanks Anshum. I took a look and have some comments:
* REBALANCELEADERS: I don't see any Request object for this?
* CREATEALIAS and DELETEALIAS: their 'name' parameter denotes something different than Create/Delete (it's the alias name vs the collection name)
* CLUSTERSTATUS: also takes a collection and shard parameters, so it can remain under CollectionShardAdminRequest
* MIGRATE: only needs collection, not shard, so I moved it to extend CollectionAdminRequest.
> Fix Collections API SolrJ calls to not add name parameter when not needed
> -------------------------------------------------------------------------
>
> Key: SOLR-7298
> URL: https://issues.apache.org/jira/browse/SOLR-7298
> Project: Solr
> Issue Type: Bug
> Components: SolrCloud, SolrJ
> Affects Versions: 5.0
> Reporter: Anshum Gupta
> Attachments: SOLR-7298.patch, collection_api_params.xls
>
>
> Collections API SolrJ calls add the name parameter for a lot of calls incorrectly. It should only be added when required.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org