You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hive.apache.org by "Sahil Takiar (JIRA)" <ji...@apache.org> on 2017/09/18 20:03:00 UTC

[jira] [Commented] (HIVE-17112) Reduce logging in HiveSparkClientFactory and RemoteHiveSparkClient

    [ https://issues.apache.org/jira/browse/HIVE-17112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16170591#comment-16170591 ] 

Sahil Takiar commented on HIVE-17112:
-------------------------------------

[~xuefuz] could you review this? What do you think about making this change? I don't think its necessary to dump the configuration at {{INFO}} level, {{DEBUG}} level seems more appropriate.

> Reduce logging in HiveSparkClientFactory and RemoteHiveSparkClient
> ------------------------------------------------------------------
>
>                 Key: HIVE-17112
>                 URL: https://issues.apache.org/jira/browse/HIVE-17112
>             Project: Hive
>          Issue Type: Improvement
>          Components: Spark
>            Reporter: Sahil Takiar
>            Assignee: Sahil Takiar
>         Attachments: HIVE-17112.1.patch
>
>
> HiveSparkClientFactory has the following line that introduces excess logging:
> {code}
> LOG.info(String.format(
>               "load spark property from %s (%s -> %s).",
>               SPARK_DEFAULT_CONF_FILE, propertyName, LogUtils.maskIfPassword(propertyName,value)));
> {code}
> It basically dumps the entire configuration object to the logs, we can probably change this from INFO to DEBUG.
> Same thing happens in {{RemoteHiveSparkClient#logConfigurations}}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)