You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "essobedo (via GitHub)" <gi...@apache.org> on 2023/10/31 14:19:56 UTC
[PR] CAMEL-20039: camel-core - SimpleLRUCache add support for soft cache [camel]
essobedo opened a new pull request, #11876:
URL: https://github.com/apache/camel/pull/11876
Fix for https://issues.apache.org/jira/browse/CAMEL-20039
## Motivation
To prevent OOME, we need to provide a soft cache.
## Modifications:
* Convert the static inner class `SimpleLRUCache` into a main class to be able to reuse it easily
* Add a decorator of Map called `SimpleSoftCache` to convert a map into a soft cache
* Modify the `DefaultLRUCacheFactory` to return a soft cache when calling methods `createLRUWeakCache` and `createLRUSoftCache`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-20039: camel-core - SimpleLRUCache add support for soft cache [camel]
Posted by "essobedo (via GitHub)" <gi...@apache.org>.
essobedo merged PR #11876:
URL: https://github.com/apache/camel/pull/11876
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-20039: camel-core - SimpleLRUCache add support for soft cache [camel]
Posted by "essobedo (via GitHub)" <gi...@apache.org>.
essobedo commented on PR #11876:
URL: https://github.com/apache/camel/pull/11876#issuecomment-1787386096
The failing test is `FileConsumerPreMoveDeleteTest.testPreMoveDeleteSameFileTwice`, it doesn't seem to be related as it passes locally
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-20039: camel-core - SimpleLRUCache add support for soft cache [camel]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #11876:
URL: https://github.com/apache/camel/pull/11876#issuecomment-1787315329
:star2: Thank you for your contribution to the Apache Camel project! :star2:
:robot: CI automation will test this PR automatically.
:camel: Apache Camel Committers, please review the following items:
* First-time contributors **require MANUAL approval** for the GitHub Actions to run
* You can use the command `/component-test (camel-)component-name1 (camel-)component-name2..` to request a test from the test bot.
* You can label PRs using `build-all`, `build-dependents`, `skip-tests` and `test-dependents` to fine-tune the checks executed by this PR.
* Build and test logs are available in the Summary page. **Only** [Apache Camel committers](https://camel.apache.org/community/team/#committers) have access to the summary.
* :warning: Be careful when sharing logs. Review their contents before sharing them publicly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-20039: camel-core - SimpleLRUCache add support for soft cache [camel]
Posted by "essobedo (via GitHub)" <gi...@apache.org>.
essobedo commented on PR #11876:
URL: https://github.com/apache/camel/pull/11876#issuecomment-1787480688
Let's wait for the result of a full build before backporting it into 4.0.x https://ci-builds.apache.org/job/Camel/job/Camel%20JDK17/job/main/1326/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-20039: camel-core - SimpleLRUCache add support for soft cache [camel]
Posted by "essobedo (via GitHub)" <gi...@apache.org>.
essobedo commented on PR #11876:
URL: https://github.com/apache/camel/pull/11876#issuecomment-1788588344
The build raised 2 failures:
* [org.apache.camel.component.flatpack.FixedLengthAllowShortTest.testFlatpackDataFormatXML](https://ci-builds.apache.org/job/Camel/job/Camel%20JDK17/job/main/1326/testReport/junit/org.apache.camel.component.flatpack/FixedLengthAllowShortTest/testFlatpackDataFormatXML/)
* [org.apache.camel.component.grpc.GrpcProducerStreamingTest.testPingAsyncAsyncRecovery](https://ci-builds.apache.org/job/Camel/job/Camel%20JDK17/job/main/1326/testReport/junit/org.apache.camel.component.grpc/GrpcProducerStreamingTest/testPingAsyncAsyncRecovery/)
However, if I launch all the tests of those 2 components locally, the tests pass so I assume that it is not related to those changes, let's backport it then
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org