You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opendal.apache.org by "caicancai (via GitHub)" <gi...@apache.org> on 2023/11/09 11:54:10 UTC
[PR] [feat/c]: Change the cpp file in the test folder to c [incubator-opendal]
caicancai opened a new pull request, #3547:
URL: https://github.com/apache/incubator-opendal/pull/3547
The test file of c is cpp, although cpp and c are compatible, but I think the test file is more compliant with the specification
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat/c: Change the cpp file in the test folder to c [incubator-opendal]
Posted by "caicancai (via GitHub)" <gi...@apache.org>.
caicancai commented on PR #3547:
URL: https://github.com/apache/incubator-opendal/pull/3547#issuecomment-1803706966
This may be a bad habit of mine, I will focus on the code later
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat/c: Change the cpp file in the test folder to c [incubator-opendal]
Posted by "caicancai (via GitHub)" <gi...@apache.org>.
caicancai commented on PR #3547:
URL: https://github.com/apache/incubator-opendal/pull/3547#issuecomment-1803704127
> This PR is meaningless. Please focus improving code instead of doing things like this one.
ok, Thank you. I'm looking at this part of the code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat/c: Change the cpp file in the test folder to c [incubator-opendal]
Posted by "Ji-Xinyou (via GitHub)" <gi...@apache.org>.
Ji-Xinyou commented on PR #3547:
URL: https://github.com/apache/incubator-opendal/pull/3547#issuecomment-1804670373
We are using cpp because we want to use the STL(vector, string, etc.) and other framework(gtest) for more clean and easy testing codes. Changing this to C adds more meaningless complexity and break the current tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat/c: Change the cpp file in the test folder to c [incubator-opendal]
Posted by "caicancai (via GitHub)" <gi...@apache.org>.
caicancai closed pull request #3547: feat/c: Change the cpp file in the test folder to c
URL: https://github.com/apache/incubator-opendal/pull/3547
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat/c: Change the cpp file in the test folder to c [incubator-opendal]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on PR #3547:
URL: https://github.com/apache/incubator-opendal/pull/3547#issuecomment-1803701209
This PR is meaningless. Please focus improving code instead of doing things like this one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org