You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/01/31 09:45:42 UTC
[GitHub] [flink] StephanEwen opened a new pull request #10982:
[FLINK-15683][docs] Restructure Configuration page
StephanEwen opened a new pull request #10982: [FLINK-15683][docs] Restructure Configuration page
URL: https://github.com/apache/flink/pull/10982
## What is the purpose of the change
This restructures the documentation page to make it less confusing and more easily digestible for users. This also removes some outdated/confusing/misleading background sections.
The improvements are twofold:
- Group the parameters by "use case" and "user-facing behavior", rather than by the class in which they are defined.
- Distinguish between parameters that are required or typically use to set up some functionality, and parameters you should not worry about in most cases (only you really need to do advanced trouble-shooting).
## Follow-up
This PR does not yet update and descriptions or resolve the issue that `(none)` as the default value does not tell the user if this is a required parameter (for a certain feature), it has an internal default behavior or fallback, or it is purely optional.
## Brief change log
Main changes:
- Generalize the `@CommonOption` annotation to `@Section` to support putting options in different (multiple) sections independent of the source code file in which they are defined
- Rework the configuration.md page to set up a different structure of grouping the options
https://github.com/apache/flink/compare/master...StephanEwen:restructure_docs?expand=1#diff-b98ef45d30f932983679d102102dd8f0
Additional changes:
- Removes outdated section on HDFS config variables
- Removes outdated background section and places extra links to other parts of the docs in the relevant sections.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] StephanEwen commented on issue #10982: [FLINK-15683][docs]
Restructure Configuration page
Posted by GitBox <gi...@apache.org>.
StephanEwen commented on issue #10982: [FLINK-15683][docs] Restructure Configuration page
URL: https://github.com/apache/flink/pull/10982#issuecomment-581781839
Merged in
- `master` in d6a7b01d2424bdf81fce124948bd33ea05a6ce3b
- `release-1.10` in 5729f237d2c3f01efc3ebc70d051bec09381fcc8
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] aljoscha commented on a change in pull request #10982:
[FLINK-15683][docs] Restructure Configuration page
Posted by GitBox <gi...@apache.org>.
aljoscha commented on a change in pull request #10982: [FLINK-15683][docs] Restructure Configuration page
URL: https://github.com/apache/flink/pull/10982#discussion_r373412691
##########
File path: docs/ops/config.md
##########
@@ -23,213 +23,407 @@ specific language governing permissions and limitations
under the License.
-->
-**For single-node setups Flink is ready to go out of the box and you don't need to change the default configuration to get started.**
+All configuration is done in `conf/flink-conf.yaml`, which is expected to be a flat collection of [YAML key value pairs](http://www.yaml.org/spec/1.2/spec.html) with format `key: value`.
+
+The configuration is parsed and evaluated when the Flink processes are started. Changes to the configuration file require restarting the relevant processes.
The out of the box configuration will use your default Java installation. You can manually set the environment variable `JAVA_HOME` or the configuration key `env.java.home` in `conf/flink-conf.yaml` if you want to manually override the Java runtime to use.
-This page lists the most common options that are typically needed to set up a well performing (distributed) installation. In addition a full list of all available configuration parameters is listed here.
+* This will be replaced by the TOC
+{:toc}
-All configuration is done in `conf/flink-conf.yaml`, which is expected to be a flat collection of [YAML key value pairs](http://www.yaml.org/spec/1.2/spec.html) with format `key: value`.
+# Basic Setup
-The system and run scripts parse the config at startup time. Changes to the configuration file require restarting the Flink JobManager and TaskManagers.
+The default configuration supports starting a single-node Flink session cluster without any changes.
+The options in this section are the ones most commonly needed for a basic distributed Flink setup.
-The configuration files for the TaskManagers can be different, Flink does not assume uniform machines in the cluster.
+**Hostnames / Ports**
-* This will be replaced by the TOC
-{:toc}
+These options are only necessary for a *standalone* application- or session deployments ([simple standalone]({{site.baseurl}}/ops/deployment/cluster_setup.html) or [Kubernetes]({{site.baseurl}}/ops/deployment/kubernetes.html)).
-## Common Options
+If you use Flink with [Yarn]({{site.baseurl}}/ops/deployment/yarn_setup.html), [Mesos]({{site.baseurl}}/ops/deployment/mesos.html), or the [*active* Kubernetes integration]({{site.baseurl}}/ops/deployment/native_kubernetes.html), the hostnames and ports get automatically configured are automatically discovered.
-{% include generated/common_section.html %}
+ - `rest.address`, `rest.port`: These are used by the client to connect to Flink. Set this to the hostname where the master (JobManager) runs, or to the hostname of the (Kubernetes) service in front of the Flink Master's REST interface.
-## Full Reference
+ - The `jobmanager.rpc.address` (defaults to *"localhost"*) and `jobmanager.rpc.port` (defaults to *6123*) config entries are used by the TaskManager to connect to the JobManager/ResourceManager. Set this to the hostname where the master (JobManager) runs, or to the hostname of the (Kubernetes internal) service for the Flink master (JobManager). This option is ignored on [setups with high-availability]({{site.baseurl}}/ops/jobmanager_high_availability.html) where the leader election mechanism is used to discover this automatically.
-### Core
+**Memory Sizes**
-{% include generated/core_configuration.html %}
+The default memory sizes support simple streaming/batch applications, but are too low to yield good performance on more complex applications.
-### Execution
+ - `jobmanager.heap.size`: Sets the size of the *Flink Master* (JobManager / ResourceManager / Dispatcher) JVM heap.
+ - `taskmanager.memory.process.size`: Total size of the TaskManager process, including everything. Flink will subtract some memory for the JVM's own memory requirements (metaspace and others), and divide and configure the rest automatically between its components (network, managed memory, JVM Heap, etc.).
-{% include generated/deployment_configuration.html %}
-{% include generated/savepoint_config_configuration.html %}
-{% include generated/execution_configuration.html %}
+These value are configured as memory sizes, for example *1536m* or *2g*.
+
+**Parallelism**
+
+ - `taskmanager.numberOfTaskSlots`: The number of slots that a TaskManager offers *(default: 1)*. Each slot can take one task or pipeline.
+ Having multiple slots in a TaskManager can help amortize certain constant overheads (of the JVM, application libraries, or network connections) across parallel tasks or pipelines.
+
+ Running more smaller TaskManagers with one slot each is a good starting point and leads to the best isolation between tasks. Dedicating the same resources to fewer larger TaskManagers with more slots can help to increase resource utilization, at the cost of weaker isolation between the tasks (more tasks share the same JVM).
+
+ - `parallelism.default`: The default parallelism used when no parallelism is specified anywhere *(default: 1)*.
+
+**Checkpointing**
+
+You can configure checkpointing directly in code within your Flink job or application. Putting these values here in the configuration defines them as defaults in case the application does not configure anything.
+
+ - `state.backend`: The state backend to use. This defines the data structure mechanism for taking snapshots. Common values are `filesystem` or `rocksdb`.
+ - `state.checkpoints.dir`: The directory to write checkpoints to. This takes a path URI like *s3://mybucket/flink-app/checkpoints* or *hdfs://namenode:port/flink/checkpoints*.
+ - `state.savepoints.dir`: The default directory for savepoints. Takes a path URI, similar to `state.checkpoints.dir`.
-### JobManager
+**Web UI**
-{% include generated/job_manager_configuration.html %}
+ - `web.submit.enable`: Enables uploading and starting jobs through the Flink UI *(true by default)*. Please note that even when this is disabled, session clusters still accept jobs through REST requests (HTTP calls). This flag only guards the feature to upload jobs in the UI.
+ - `web.upload.dir`: The directory where to store uploaded jobs. Only used when `web.submit.enable` is true.
-### Restart Strategies
+**Other**
-Configuration options to control Flink's restart behaviour in case of job failures.
+ - `io.tmp.dirs`: The directories where Flink puts local data, defaults to the system temp directory (`java.io.tmpdir` property). If a list of directories is configured, Flink will rotate files across the directories.
+
+ The data put in these directories include by default the files created by RocksDB, spilled intermediate results (batch algorithms), and cached jar files.
+
+ This data is NOT relied upon for persistence/recovery, but if this data gets deleted, it typically causes a heavyweight recovery operation. It is hence recommended to set this to a directory that is not automatically periodically purged.
+
+ Yarn, Mesos, and Kubernets setups automatically configure this value to the local working directories by default.
Review comment:
```suggestion
Yarn, Mesos, and Kubernetes setups automatically configure this value to the local working directories by default.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zentol commented on issue #10982: [FLINK-15683][docs]
Restructure Configuration page
Posted by GitBox <gi...@apache.org>.
zentol commented on issue #10982: [FLINK-15683][docs] Restructure Configuration page
URL: https://github.com/apache/flink/pull/10982#issuecomment-580710330
While the separate into common/expert options makes sense, it seems quite inconvenient to not have them in unified form _somewhere_.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zentol commented on a change in pull request #10982:
[FLINK-15683][docs] Restructure Configuration page
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #10982: [FLINK-15683][docs] Restructure Configuration page
URL: https://github.com/apache/flink/pull/10982#discussion_r373641949
##########
File path: flink-core/src/main/java/org/apache/flink/configuration/SecurityOptions.java
##########
@@ -95,6 +94,7 @@
* @deprecated Use {@link #SSL_INTERNAL_ENABLED} and {@link #SSL_REST_ENABLED} instead.
*/
@Deprecated
+ @Documentation.ExcludeFromDocumentation
Review comment:
FYI, deprecated options are already excluded from the documentation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] aljoscha commented on a change in pull request #10982:
[FLINK-15683][docs] Restructure Configuration page
Posted by GitBox <gi...@apache.org>.
aljoscha commented on a change in pull request #10982: [FLINK-15683][docs] Restructure Configuration page
URL: https://github.com/apache/flink/pull/10982#discussion_r373411912
##########
File path: docs/ops/config.md
##########
@@ -23,213 +23,407 @@ specific language governing permissions and limitations
under the License.
-->
-**For single-node setups Flink is ready to go out of the box and you don't need to change the default configuration to get started.**
+All configuration is done in `conf/flink-conf.yaml`, which is expected to be a flat collection of [YAML key value pairs](http://www.yaml.org/spec/1.2/spec.html) with format `key: value`.
+
+The configuration is parsed and evaluated when the Flink processes are started. Changes to the configuration file require restarting the relevant processes.
The out of the box configuration will use your default Java installation. You can manually set the environment variable `JAVA_HOME` or the configuration key `env.java.home` in `conf/flink-conf.yaml` if you want to manually override the Java runtime to use.
-This page lists the most common options that are typically needed to set up a well performing (distributed) installation. In addition a full list of all available configuration parameters is listed here.
+* This will be replaced by the TOC
+{:toc}
-All configuration is done in `conf/flink-conf.yaml`, which is expected to be a flat collection of [YAML key value pairs](http://www.yaml.org/spec/1.2/spec.html) with format `key: value`.
+# Basic Setup
-The system and run scripts parse the config at startup time. Changes to the configuration file require restarting the Flink JobManager and TaskManagers.
+The default configuration supports starting a single-node Flink session cluster without any changes.
+The options in this section are the ones most commonly needed for a basic distributed Flink setup.
-The configuration files for the TaskManagers can be different, Flink does not assume uniform machines in the cluster.
+**Hostnames / Ports**
-* This will be replaced by the TOC
-{:toc}
+These options are only necessary for a *standalone* application- or session deployments ([simple standalone]({{site.baseurl}}/ops/deployment/cluster_setup.html) or [Kubernetes]({{site.baseurl}}/ops/deployment/kubernetes.html)).
Review comment:
```suggestion
These options are only necessary for *standalone* application- or session deployments ([simple standalone]({{site.baseurl}}/ops/deployment/cluster_setup.html) or [Kubernetes]({{site.baseurl}}/ops/deployment/kubernetes.html)).
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] StephanEwen commented on a change in pull request #10982:
[FLINK-15683][docs] Restructure Configuration page
Posted by GitBox <gi...@apache.org>.
StephanEwen commented on a change in pull request #10982: [FLINK-15683][docs] Restructure Configuration page
URL: https://github.com/apache/flink/pull/10982#discussion_r373548350
##########
File path: flink-annotations/src/main/java/org/apache/flink/annotation/docs/Documentation.java
##########
@@ -41,24 +41,67 @@
}
/**
- * Annotation used on config option fields to include them in the "Common Options" section.
+ * Annotation used on config option fields to include them in specific sections. Sections are groups of options
+ * that are aggregated across option classes, with each group being placed into a dedicated file.
*
- * <p>The {@link CommonOption#position()} argument controls the position in the generated table, with lower values
+ * <p>The {@link Section#position()} argument controls the position in the generated table, with lower values
* being placed at the top. Fields with the same position are sorted alphabetically by key.
*/
@Target(ElementType.FIELD)
@Retention(RetentionPolicy.RUNTIME)
@Internal
- public @interface CommonOption {
- int POSITION_MEMORY = 10;
- int POSITION_PARALLELISM_SLOTS = 20;
- int POSITION_FAULT_TOLERANCE = 30;
- int POSITION_HIGH_AVAILABILITY = 40;
- int POSITION_SECURITY = 50;
+ public @interface Section {
+ String SECTION_COMMON = "common";
Review comment:
Actually not, no, this variable is unused. Can remove it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10982:
[FLINK-15683][docs] Restructure Configuration page
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10982: [FLINK-15683][docs] Restructure Configuration page
URL: https://github.com/apache/flink/pull/10982#issuecomment-580670279
<!--
Meta data
Hash:227476016717c1da4d21aaa3c9bb1e14b47b0e4f Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/146897292 TriggerType:PUSH TriggerID:227476016717c1da4d21aaa3c9bb1e14b47b0e4f
Hash:227476016717c1da4d21aaa3c9bb1e14b47b0e4f Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4712 TriggerType:PUSH TriggerID:227476016717c1da4d21aaa3c9bb1e14b47b0e4f
Hash:02696f5cee5c1ae7e1fc473992648e56460e7257 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/146901924 TriggerType:PUSH TriggerID:02696f5cee5c1ae7e1fc473992648e56460e7257
Hash:02696f5cee5c1ae7e1fc473992648e56460e7257 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4717 TriggerType:PUSH TriggerID:02696f5cee5c1ae7e1fc473992648e56460e7257
Hash:87b11249448e44d97567fd8dd23bbf1acd9800e1 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/146965824 TriggerType:PUSH TriggerID:87b11249448e44d97567fd8dd23bbf1acd9800e1
Hash:87b11249448e44d97567fd8dd23bbf1acd9800e1 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4741 TriggerType:PUSH TriggerID:87b11249448e44d97567fd8dd23bbf1acd9800e1
-->
## CI report:
* 227476016717c1da4d21aaa3c9bb1e14b47b0e4f Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/146897292) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4712)
* 02696f5cee5c1ae7e1fc473992648e56460e7257 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/146901924) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4717)
* 87b11249448e44d97567fd8dd23bbf1acd9800e1 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/146965824) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4741)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] StephanEwen commented on issue #10982: [FLINK-15683][docs]
Restructure Configuration page
Posted by GitBox <gi...@apache.org>.
StephanEwen commented on issue #10982: [FLINK-15683][docs] Restructure Configuration page
URL: https://github.com/apache/flink/pull/10982#issuecomment-580839537
Pushed a some fixes
- including the previously missing generated section `expert_security_ssl_section.html`
- Fixing the tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zentol commented on a change in pull request #10982:
[FLINK-15683][docs] Restructure Configuration page
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #10982: [FLINK-15683][docs] Restructure Configuration page
URL: https://github.com/apache/flink/pull/10982#discussion_r373446617
##########
File path: flink-core/src/main/java/org/apache/flink/configuration/HighAvailabilityOptions.java
##########
@@ -29,10 +27,6 @@
/**
* The set of configuration options relating to high-availability settings.
*/
-@PublicEvolving
-@ConfigGroups(groups = {
Review comment:
Are the re actually any usages left of ConfigGroups?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zentol commented on a change in pull request #10982:
[FLINK-15683][docs] Restructure Configuration page
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #10982: [FLINK-15683][docs] Restructure Configuration page
URL: https://github.com/apache/flink/pull/10982#discussion_r373448910
##########
File path: flink-annotations/src/main/java/org/apache/flink/annotation/docs/Documentation.java
##########
@@ -41,24 +41,67 @@
}
/**
- * Annotation used on config option fields to include them in the "Common Options" section.
+ * Annotation used on config option fields to include them in specific sections. Sections are groups of options
+ * that are aggregated across option classes, with each group being placed into a dedicated file.
*
- * <p>The {@link CommonOption#position()} argument controls the position in the generated table, with lower values
+ * <p>The {@link Section#position()} argument controls the position in the generated table, with lower values
* being placed at the top. Fields with the same position are sorted alphabetically by key.
*/
@Target(ElementType.FIELD)
@Retention(RetentionPolicy.RUNTIME)
@Internal
- public @interface CommonOption {
- int POSITION_MEMORY = 10;
- int POSITION_PARALLELISM_SLOTS = 20;
- int POSITION_FAULT_TOLERANCE = 30;
- int POSITION_HIGH_AVAILABILITY = 40;
- int POSITION_SECURITY = 50;
+ public @interface Section {
+ String SECTION_COMMON = "common";
Review comment:
`common_section.html` isn't used anymore, but it seems like some classes are still grouped into a generic common section.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zentol commented on a change in pull request #10982:
[FLINK-15683][docs] Restructure Configuration page
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #10982: [FLINK-15683][docs] Restructure Configuration page
URL: https://github.com/apache/flink/pull/10982#discussion_r373779422
##########
File path: flink-core/src/main/java/org/apache/flink/configuration/SecurityOptions.java
##########
@@ -33,34 +30,33 @@
/**
* The set of configuration options relating to security.
*/
-@PublicEvolving
-@ConfigGroups(groups = {
- @ConfigGroup(name = "Kerberos", keyPrefix = "security.kerberos"),
Review comment:
The core issue I have here is that we introduce an inconsistency in how options are translated into include files, which make it impossible to implement any safeguards to prevent dev errors. In my example above, the generator won't complain about a new ssl option being added without a common/expert annotation, because it will still be added to the file we generate for each config class by default, and the generator assumes that all include files are used in the documentation.
If on the other hand we would completely remove config groups, and the default include file per config class, then we could mandate that every new option must have a section annotation. This we could easily enforce.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10982:
[FLINK-15683][docs] Restructure Configuration page
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10982: [FLINK-15683][docs] Restructure Configuration page
URL: https://github.com/apache/flink/pull/10982#issuecomment-580670279
<!--
Meta data
Hash:227476016717c1da4d21aaa3c9bb1e14b47b0e4f Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/146897292 TriggerType:PUSH TriggerID:227476016717c1da4d21aaa3c9bb1e14b47b0e4f
Hash:227476016717c1da4d21aaa3c9bb1e14b47b0e4f Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4712 TriggerType:PUSH TriggerID:227476016717c1da4d21aaa3c9bb1e14b47b0e4f
Hash:02696f5cee5c1ae7e1fc473992648e56460e7257 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/146901924 TriggerType:PUSH TriggerID:02696f5cee5c1ae7e1fc473992648e56460e7257
Hash:02696f5cee5c1ae7e1fc473992648e56460e7257 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4717 TriggerType:PUSH TriggerID:02696f5cee5c1ae7e1fc473992648e56460e7257
Hash:87b11249448e44d97567fd8dd23bbf1acd9800e1 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/146965824 TriggerType:PUSH TriggerID:87b11249448e44d97567fd8dd23bbf1acd9800e1
Hash:87b11249448e44d97567fd8dd23bbf1acd9800e1 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4741 TriggerType:PUSH TriggerID:87b11249448e44d97567fd8dd23bbf1acd9800e1
-->
## CI report:
* 227476016717c1da4d21aaa3c9bb1e14b47b0e4f Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/146897292) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4712)
* 02696f5cee5c1ae7e1fc473992648e56460e7257 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/146901924) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4717)
* 87b11249448e44d97567fd8dd23bbf1acd9800e1 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/146965824) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4741)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] StephanEwen commented on issue #10982: [FLINK-15683][docs]
Restructure Configuration page
Posted by GitBox <gi...@apache.org>.
StephanEwen commented on issue #10982: [FLINK-15683][docs] Restructure Configuration page
URL: https://github.com/apache/flink/pull/10982#issuecomment-580790154
The "expert_security_ssl_section.htm" was overlooked. Trying to adjust the coverage tests (they currently fail) to make sure these things are called automatically now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] aljoscha commented on a change in pull request #10982:
[FLINK-15683][docs] Restructure Configuration page
Posted by GitBox <gi...@apache.org>.
aljoscha commented on a change in pull request #10982: [FLINK-15683][docs] Restructure Configuration page
URL: https://github.com/apache/flink/pull/10982#discussion_r373411687
##########
File path: docs/ops/config.md
##########
@@ -23,213 +23,407 @@ specific language governing permissions and limitations
under the License.
-->
-**For single-node setups Flink is ready to go out of the box and you don't need to change the default configuration to get started.**
+All configuration is done in `conf/flink-conf.yaml`, which is expected to be a flat collection of [YAML key value pairs](http://www.yaml.org/spec/1.2/spec.html) with format `key: value`.
+
+The configuration is parsed and evaluated when the Flink processes are started. Changes to the configuration file require restarting the relevant processes.
The out of the box configuration will use your default Java installation. You can manually set the environment variable `JAVA_HOME` or the configuration key `env.java.home` in `conf/flink-conf.yaml` if you want to manually override the Java runtime to use.
-This page lists the most common options that are typically needed to set up a well performing (distributed) installation. In addition a full list of all available configuration parameters is listed here.
+* This will be replaced by the TOC
+{:toc}
-All configuration is done in `conf/flink-conf.yaml`, which is expected to be a flat collection of [YAML key value pairs](http://www.yaml.org/spec/1.2/spec.html) with format `key: value`.
+# Basic Setup
-The system and run scripts parse the config at startup time. Changes to the configuration file require restarting the Flink JobManager and TaskManagers.
+The default configuration supports starting a single-node Flink session cluster without any changes.
+The options in this section are the ones most commonly needed for a basic distributed Flink setup.
-The configuration files for the TaskManagers can be different, Flink does not assume uniform machines in the cluster.
+**Hostnames / Ports**
-* This will be replaced by the TOC
-{:toc}
+These options are only necessary for a *standalone* application- or session deployments ([simple standalone]({{site.baseurl}}/ops/deployment/cluster_setup.html) or [Kubernetes]({{site.baseurl}}/ops/deployment/kubernetes.html)).
-## Common Options
+If you use Flink with [Yarn]({{site.baseurl}}/ops/deployment/yarn_setup.html), [Mesos]({{site.baseurl}}/ops/deployment/mesos.html), or the [*active* Kubernetes integration]({{site.baseurl}}/ops/deployment/native_kubernetes.html), the hostnames and ports get automatically configured are automatically discovered.
Review comment:
```suggestion
If you use Flink with [Yarn]({{site.baseurl}}/ops/deployment/yarn_setup.html), [Mesos]({{site.baseurl}}/ops/deployment/mesos.html), or the [*active* Kubernetes integration]({{site.baseurl}}/ops/deployment/native_kubernetes.html), the hostnames and ports are automatically discovered.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zentol commented on a change in pull request #10982:
[FLINK-15683][docs] Restructure Configuration page
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #10982: [FLINK-15683][docs] Restructure Configuration page
URL: https://github.com/apache/flink/pull/10982#discussion_r373651280
##########
File path: flink-core/src/main/java/org/apache/flink/configuration/SecurityOptions.java
##########
@@ -33,34 +30,33 @@
/**
* The set of configuration options relating to security.
*/
-@PublicEvolving
-@ConfigGroups(groups = {
- @ConfigGroup(name = "Kerberos", keyPrefix = "security.kerberos"),
Review comment:
> section option [ are] simpler
This is debatable. The ConfigGroups were written on purpose the way they are so that devs can add new options without having to worry or even know how the docs are generated. You could just add a new kerberos option and it _would just work_.
Meanwhile, if a dev now adds an option they have to decide whether the option is common/expert, and if they forget to add any of the annotations are at risk of the option not being documented at all.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zentol commented on a change in pull request #10982:
[FLINK-15683][docs] Restructure Configuration page
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #10982: [FLINK-15683][docs] Restructure Configuration page
URL: https://github.com/apache/flink/pull/10982#discussion_r373651280
##########
File path: flink-core/src/main/java/org/apache/flink/configuration/SecurityOptions.java
##########
@@ -33,34 +30,33 @@
/**
* The set of configuration options relating to security.
*/
-@PublicEvolving
-@ConfigGroups(groups = {
- @ConfigGroup(name = "Kerberos", keyPrefix = "security.kerberos"),
Review comment:
> section option [are] simpler
This is debatable. The ConfigGroups were written on purpose the way they are so that devs can add new options without having to worry or even know how the docs are generated. You could just add a new kerberos option and it _would just work_.
Meanwhile, if a dev now adds an option they have to decide whether the option is common/expert, and if they forget to add any of the annotations are at risk of the option not being documented at all.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10982:
[FLINK-15683][docs] Restructure Configuration page
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10982: [FLINK-15683][docs] Restructure Configuration page
URL: https://github.com/apache/flink/pull/10982#issuecomment-580670279
<!--
Meta data
Hash:227476016717c1da4d21aaa3c9bb1e14b47b0e4f Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/146897292 TriggerType:PUSH TriggerID:227476016717c1da4d21aaa3c9bb1e14b47b0e4f
Hash:227476016717c1da4d21aaa3c9bb1e14b47b0e4f Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4712 TriggerType:PUSH TriggerID:227476016717c1da4d21aaa3c9bb1e14b47b0e4f
Hash:02696f5cee5c1ae7e1fc473992648e56460e7257 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/146901924 TriggerType:PUSH TriggerID:02696f5cee5c1ae7e1fc473992648e56460e7257
Hash:02696f5cee5c1ae7e1fc473992648e56460e7257 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4717 TriggerType:PUSH TriggerID:02696f5cee5c1ae7e1fc473992648e56460e7257
Hash:87b11249448e44d97567fd8dd23bbf1acd9800e1 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/146965824 TriggerType:PUSH TriggerID:87b11249448e44d97567fd8dd23bbf1acd9800e1
Hash:87b11249448e44d97567fd8dd23bbf1acd9800e1 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4741 TriggerType:PUSH TriggerID:87b11249448e44d97567fd8dd23bbf1acd9800e1
Hash:3129d7f85d1ed3469b87ebe5813f035d1092d195 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:3129d7f85d1ed3469b87ebe5813f035d1092d195
-->
## CI report:
* 227476016717c1da4d21aaa3c9bb1e14b47b0e4f Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/146897292) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4712)
* 02696f5cee5c1ae7e1fc473992648e56460e7257 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/146901924) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4717)
* 87b11249448e44d97567fd8dd23bbf1acd9800e1 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/146965824) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4741)
* 3129d7f85d1ed3469b87ebe5813f035d1092d195 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10982:
[FLINK-15683][docs] Restructure Configuration page
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10982: [FLINK-15683][docs] Restructure Configuration page
URL: https://github.com/apache/flink/pull/10982#issuecomment-580670279
<!--
Meta data
Hash:227476016717c1da4d21aaa3c9bb1e14b47b0e4f Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/146897292 TriggerType:PUSH TriggerID:227476016717c1da4d21aaa3c9bb1e14b47b0e4f
Hash:227476016717c1da4d21aaa3c9bb1e14b47b0e4f Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4712 TriggerType:PUSH TriggerID:227476016717c1da4d21aaa3c9bb1e14b47b0e4f
Hash:02696f5cee5c1ae7e1fc473992648e56460e7257 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/146901924 TriggerType:PUSH TriggerID:02696f5cee5c1ae7e1fc473992648e56460e7257
Hash:02696f5cee5c1ae7e1fc473992648e56460e7257 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4717 TriggerType:PUSH TriggerID:02696f5cee5c1ae7e1fc473992648e56460e7257
-->
## CI report:
* 227476016717c1da4d21aaa3c9bb1e14b47b0e4f Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/146897292) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4712)
* 02696f5cee5c1ae7e1fc473992648e56460e7257 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/146901924) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4717)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10982:
[FLINK-15683][docs] Restructure Configuration page
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10982: [FLINK-15683][docs] Restructure Configuration page
URL: https://github.com/apache/flink/pull/10982#issuecomment-580670279
<!--
Meta data
Hash:227476016717c1da4d21aaa3c9bb1e14b47b0e4f Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/146897292 TriggerType:PUSH TriggerID:227476016717c1da4d21aaa3c9bb1e14b47b0e4f
Hash:227476016717c1da4d21aaa3c9bb1e14b47b0e4f Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4712 TriggerType:PUSH TriggerID:227476016717c1da4d21aaa3c9bb1e14b47b0e4f
Hash:02696f5cee5c1ae7e1fc473992648e56460e7257 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:02696f5cee5c1ae7e1fc473992648e56460e7257
-->
## CI report:
* 227476016717c1da4d21aaa3c9bb1e14b47b0e4f Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/146897292) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4712)
* 02696f5cee5c1ae7e1fc473992648e56460e7257 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10982: [FLINK-15683][docs]
Restructure Configuration page
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10982: [FLINK-15683][docs] Restructure Configuration page
URL: https://github.com/apache/flink/pull/10982#issuecomment-580662670
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit f69112114977664c17807a37cf73fbf1a2df064e (Fri Jan 31 09:47:23 UTC 2020)
**Warnings:**
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-15683).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] StephanEwen commented on issue #10982: [FLINK-15683][docs]
Restructure Configuration page
Posted by GitBox <gi...@apache.org>.
StephanEwen commented on issue #10982: [FLINK-15683][docs] Restructure Configuration page
URL: https://github.com/apache/flink/pull/10982#issuecomment-580879879
I can add a notice why these are excluded.
Side note: the `local.number-resourcemanager` options (and similar `local.*`) should never have been a documented option in the first place. These were only used to be passed to the mini cluster, never had any effect in the `flink-conf.yaml`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] StephanEwen commented on issue #10982: [FLINK-15683][docs]
Restructure Configuration page
Posted by GitBox <gi...@apache.org>.
StephanEwen commented on issue #10982: [FLINK-15683][docs] Restructure Configuration page
URL: https://github.com/apache/flink/pull/10982#issuecomment-580787500
About the layout / splitting. Would be happy if someone would make another pass after that and further improve this. The stat here is the best that came to my mind and it should already be much better than what we have at the moment, the benefits outweigh the problems by far, so would like to not hold it back for now.
About excluded options: I think I excluded only options that were previously also deprecated / not recommended any more.
- web.* options subsumed by rest.*
- ssl.* options that should rather be ssl.internal.* and ssl.rest.*
- miscellaneous previous oversights.
Do you see some that I accidentally excluded?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10982:
[FLINK-15683][docs] Restructure Configuration page
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10982: [FLINK-15683][docs] Restructure Configuration page
URL: https://github.com/apache/flink/pull/10982#issuecomment-580670279
<!--
Meta data
Hash:227476016717c1da4d21aaa3c9bb1e14b47b0e4f Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/146897292 TriggerType:PUSH TriggerID:227476016717c1da4d21aaa3c9bb1e14b47b0e4f
Hash:227476016717c1da4d21aaa3c9bb1e14b47b0e4f Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4712 TriggerType:PUSH TriggerID:227476016717c1da4d21aaa3c9bb1e14b47b0e4f
Hash:02696f5cee5c1ae7e1fc473992648e56460e7257 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/146901924 TriggerType:PUSH TriggerID:02696f5cee5c1ae7e1fc473992648e56460e7257
Hash:02696f5cee5c1ae7e1fc473992648e56460e7257 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4717 TriggerType:PUSH TriggerID:02696f5cee5c1ae7e1fc473992648e56460e7257
Hash:87b11249448e44d97567fd8dd23bbf1acd9800e1 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/146965824 TriggerType:PUSH TriggerID:87b11249448e44d97567fd8dd23bbf1acd9800e1
Hash:87b11249448e44d97567fd8dd23bbf1acd9800e1 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4741 TriggerType:PUSH TriggerID:87b11249448e44d97567fd8dd23bbf1acd9800e1
Hash:3129d7f85d1ed3469b87ebe5813f035d1092d195 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/147001893 TriggerType:PUSH TriggerID:3129d7f85d1ed3469b87ebe5813f035d1092d195
Hash:3129d7f85d1ed3469b87ebe5813f035d1092d195 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4743 TriggerType:PUSH TriggerID:3129d7f85d1ed3469b87ebe5813f035d1092d195
-->
## CI report:
* 227476016717c1da4d21aaa3c9bb1e14b47b0e4f Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/146897292) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4712)
* 02696f5cee5c1ae7e1fc473992648e56460e7257 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/146901924) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4717)
* 87b11249448e44d97567fd8dd23bbf1acd9800e1 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/146965824) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4741)
* 3129d7f85d1ed3469b87ebe5813f035d1092d195 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/147001893) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4743)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zentol edited a comment on issue #10982:
[FLINK-15683][docs] Restructure Configuration page
Posted by GitBox <gi...@apache.org>.
zentol edited a comment on issue #10982: [FLINK-15683][docs] Restructure Configuration page
URL: https://github.com/apache/flink/pull/10982#issuecomment-580878570
> About excluded options: I think I excluded only options that were previously [ ... ] not recommended any more.
Looking at the affected options (`ssl.*`, `local.number-resourcemanager`) there was, and _still is_, no indication that they aren't recommended anymore. Anyone looking at the option now just sees a random exclude that may have been added for a myriad of reasons.
Hence my question; all I saw was a perfectly fine looking option being excluded from the docs.
If the ssl.* options aren't supposed to be used anymore they should properly deprecated, likely with deprecated keys on the new options, as should the web option, as should `local.number-resourcemanager` since (apparently) it isn't even used anymore.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zentol commented on a change in pull request #10982:
[FLINK-15683][docs] Restructure Configuration page
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #10982: [FLINK-15683][docs] Restructure Configuration page
URL: https://github.com/apache/flink/pull/10982#discussion_r373446617
##########
File path: flink-core/src/main/java/org/apache/flink/configuration/HighAvailabilityOptions.java
##########
@@ -29,10 +27,6 @@
/**
* The set of configuration options relating to high-availability settings.
*/
-@PublicEvolving
-@ConfigGroups(groups = {
Review comment:
Are the re actually any usages left of ConfigGroups?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zentol commented on issue #10982: [FLINK-15683][docs]
Restructure Configuration page
Posted by GitBox <gi...@apache.org>.
zentol commented on issue #10982: [FLINK-15683][docs] Restructure Configuration page
URL: https://github.com/apache/flink/pull/10982#issuecomment-580709956
Please provide a reason for every option that is excluded from the documentation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] StephanEwen closed pull request #10982: [FLINK-15683][docs]
Restructure Configuration page
Posted by GitBox <gi...@apache.org>.
StephanEwen closed pull request #10982: [FLINK-15683][docs] Restructure Configuration page
URL: https://github.com/apache/flink/pull/10982
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zentol commented on a change in pull request #10982:
[FLINK-15683][docs] Restructure Configuration page
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #10982: [FLINK-15683][docs] Restructure Configuration page
URL: https://github.com/apache/flink/pull/10982#discussion_r373450579
##########
File path: flink-core/src/main/java/org/apache/flink/configuration/SecurityOptions.java
##########
@@ -33,34 +30,33 @@
/**
* The set of configuration options relating to security.
*/
-@PublicEvolving
-@ConfigGroups(groups = {
- @ConfigGroup(name = "Kerberos", keyPrefix = "security.kerberos"),
Review comment:
Why did you opt for replacing the ConfigGroups here, but kept them for `env` in `CoreOptions`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zentol commented on a change in pull request #10982:
[FLINK-15683][docs] Restructure Configuration page
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #10982: [FLINK-15683][docs] Restructure Configuration page
URL: https://github.com/apache/flink/pull/10982#discussion_r373405316
##########
File path: docs/ops/config.md
##########
@@ -23,213 +23,407 @@ specific language governing permissions and limitations
under the License.
-->
-**For single-node setups Flink is ready to go out of the box and you don't need to change the default configuration to get started.**
+All configuration is done in `conf/flink-conf.yaml`, which is expected to be a flat collection of [YAML key value pairs](http://www.yaml.org/spec/1.2/spec.html) with format `key: value`.
+
+The configuration is parsed and evaluated when the Flink processes are started. Changes to the configuration file require restarting the relevant processes.
The out of the box configuration will use your default Java installation. You can manually set the environment variable `JAVA_HOME` or the configuration key `env.java.home` in `conf/flink-conf.yaml` if you want to manually override the Java runtime to use.
-This page lists the most common options that are typically needed to set up a well performing (distributed) installation. In addition a full list of all available configuration parameters is listed here.
+* This will be replaced by the TOC
+{:toc}
-All configuration is done in `conf/flink-conf.yaml`, which is expected to be a flat collection of [YAML key value pairs](http://www.yaml.org/spec/1.2/spec.html) with format `key: value`.
+# Basic Setup
-The system and run scripts parse the config at startup time. Changes to the configuration file require restarting the Flink JobManager and TaskManagers.
+The default configuration supports starting a single-node Flink session cluster without any changes.
+The options in this section are the ones most commonly needed for a basic distributed Flink setup.
-The configuration files for the TaskManagers can be different, Flink does not assume uniform machines in the cluster.
+**Hostnames / Ports**
-* This will be replaced by the TOC
-{:toc}
+These options are only necessary for a *standalone* application- or session deployments ([simple standalone]({{site.baseurl}}/ops/deployment/cluster_setup.html) or [Kubernetes]({{site.baseurl}}/ops/deployment/kubernetes.html)).
-## Common Options
+If you use Flink with [Yarn]({{site.baseurl}}/ops/deployment/yarn_setup.html), [Mesos]({{site.baseurl}}/ops/deployment/mesos.html), or the [*active* Kubernetes integration]({{site.baseurl}}/ops/deployment/native_kubernetes.html), the hostnames and ports get automatically configured are automatically discovered.
-{% include generated/common_section.html %}
+ - `rest.address`, `rest.port`: These are used by the client to connect to Flink. Set this to the hostname where the master (JobManager) runs, or to the hostname of the (Kubernetes) service in front of the Flink Master's REST interface.
-## Full Reference
+ - The `jobmanager.rpc.address` (defaults to *"localhost"*) and `jobmanager.rpc.port` (defaults to *6123*) config entries are used by the TaskManager to connect to the JobManager/ResourceManager. Set this to the hostname where the master (JobManager) runs, or to the hostname of the (Kubernetes internal) service for the Flink master (JobManager). This option is ignored on [setups with high-availability]({{site.baseurl}}/ops/jobmanager_high_availability.html) where the leader election mechanism is used to discover this automatically.
-### Core
+**Memory Sizes**
-{% include generated/core_configuration.html %}
+The default memory sizes support simple streaming/batch applications, but are too low to yield good performance on more complex applications.
Review comment:
```suggestion
The default memory sizes support simple streaming/batch applications, but are too low to yield good performance for more complex applications.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zentol commented on a change in pull request #10982:
[FLINK-15683][docs] Restructure Configuration page
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #10982: [FLINK-15683][docs] Restructure Configuration page
URL: https://github.com/apache/flink/pull/10982#discussion_r373404941
##########
File path: docs/ops/config.md
##########
@@ -23,213 +23,407 @@ specific language governing permissions and limitations
under the License.
-->
-**For single-node setups Flink is ready to go out of the box and you don't need to change the default configuration to get started.**
+All configuration is done in `conf/flink-conf.yaml`, which is expected to be a flat collection of [YAML key value pairs](http://www.yaml.org/spec/1.2/spec.html) with format `key: value`.
+
+The configuration is parsed and evaluated when the Flink processes are started. Changes to the configuration file require restarting the relevant processes.
The out of the box configuration will use your default Java installation. You can manually set the environment variable `JAVA_HOME` or the configuration key `env.java.home` in `conf/flink-conf.yaml` if you want to manually override the Java runtime to use.
-This page lists the most common options that are typically needed to set up a well performing (distributed) installation. In addition a full list of all available configuration parameters is listed here.
+* This will be replaced by the TOC
+{:toc}
-All configuration is done in `conf/flink-conf.yaml`, which is expected to be a flat collection of [YAML key value pairs](http://www.yaml.org/spec/1.2/spec.html) with format `key: value`.
+# Basic Setup
-The system and run scripts parse the config at startup time. Changes to the configuration file require restarting the Flink JobManager and TaskManagers.
+The default configuration supports starting a single-node Flink session cluster without any changes.
+The options in this section are the ones most commonly needed for a basic distributed Flink setup.
-The configuration files for the TaskManagers can be different, Flink does not assume uniform machines in the cluster.
+**Hostnames / Ports**
-* This will be replaced by the TOC
-{:toc}
+These options are only necessary for a *standalone* application- or session deployments ([simple standalone]({{site.baseurl}}/ops/deployment/cluster_setup.html) or [Kubernetes]({{site.baseurl}}/ops/deployment/kubernetes.html)).
-## Common Options
+If you use Flink with [Yarn]({{site.baseurl}}/ops/deployment/yarn_setup.html), [Mesos]({{site.baseurl}}/ops/deployment/mesos.html), or the [*active* Kubernetes integration]({{site.baseurl}}/ops/deployment/native_kubernetes.html), the hostnames and ports get automatically configured are automatically discovered.
Review comment:
```suggestion
If you use Flink with [Yarn]({{site.baseurl}}/ops/deployment/yarn_setup.html), [Mesos]({{site.baseurl}}/ops/deployment/mesos.html), or the [*active* Kubernetes integration]({{site.baseurl}}/ops/deployment/native_kubernetes.html), the hostnames and ports get automatically configured.
```
?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10982:
[FLINK-15683][docs] Restructure Configuration page
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10982: [FLINK-15683][docs] Restructure Configuration page
URL: https://github.com/apache/flink/pull/10982#issuecomment-580670279
<!--
Meta data
Hash:227476016717c1da4d21aaa3c9bb1e14b47b0e4f Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/146897292 TriggerType:PUSH TriggerID:227476016717c1da4d21aaa3c9bb1e14b47b0e4f
Hash:227476016717c1da4d21aaa3c9bb1e14b47b0e4f Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4712 TriggerType:PUSH TriggerID:227476016717c1da4d21aaa3c9bb1e14b47b0e4f
Hash:02696f5cee5c1ae7e1fc473992648e56460e7257 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/146901924 TriggerType:PUSH TriggerID:02696f5cee5c1ae7e1fc473992648e56460e7257
Hash:02696f5cee5c1ae7e1fc473992648e56460e7257 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4717 TriggerType:PUSH TriggerID:02696f5cee5c1ae7e1fc473992648e56460e7257
-->
## CI report:
* 227476016717c1da4d21aaa3c9bb1e14b47b0e4f Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/146897292) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4712)
* 02696f5cee5c1ae7e1fc473992648e56460e7257 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/146901924) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4717)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10982:
[FLINK-15683][docs] Restructure Configuration page
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10982: [FLINK-15683][docs] Restructure Configuration page
URL: https://github.com/apache/flink/pull/10982#issuecomment-580670279
<!--
Meta data
Hash:227476016717c1da4d21aaa3c9bb1e14b47b0e4f Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/146897292 TriggerType:PUSH TriggerID:227476016717c1da4d21aaa3c9bb1e14b47b0e4f
Hash:227476016717c1da4d21aaa3c9bb1e14b47b0e4f Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4712 TriggerType:PUSH TriggerID:227476016717c1da4d21aaa3c9bb1e14b47b0e4f
Hash:02696f5cee5c1ae7e1fc473992648e56460e7257 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/146901924 TriggerType:PUSH TriggerID:02696f5cee5c1ae7e1fc473992648e56460e7257
Hash:02696f5cee5c1ae7e1fc473992648e56460e7257 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4717 TriggerType:PUSH TriggerID:02696f5cee5c1ae7e1fc473992648e56460e7257
Hash:87b11249448e44d97567fd8dd23bbf1acd9800e1 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/146965824 TriggerType:PUSH TriggerID:87b11249448e44d97567fd8dd23bbf1acd9800e1
Hash:87b11249448e44d97567fd8dd23bbf1acd9800e1 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4741 TriggerType:PUSH TriggerID:87b11249448e44d97567fd8dd23bbf1acd9800e1
Hash:3129d7f85d1ed3469b87ebe5813f035d1092d195 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/147001893 TriggerType:PUSH TriggerID:3129d7f85d1ed3469b87ebe5813f035d1092d195
Hash:3129d7f85d1ed3469b87ebe5813f035d1092d195 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4743 TriggerType:PUSH TriggerID:3129d7f85d1ed3469b87ebe5813f035d1092d195
-->
## CI report:
* 227476016717c1da4d21aaa3c9bb1e14b47b0e4f Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/146897292) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4712)
* 02696f5cee5c1ae7e1fc473992648e56460e7257 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/146901924) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4717)
* 87b11249448e44d97567fd8dd23bbf1acd9800e1 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/146965824) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4741)
* 3129d7f85d1ed3469b87ebe5813f035d1092d195 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/147001893) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4743)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zentol commented on issue #10982: [FLINK-15683][docs]
Restructure Configuration page
Posted by GitBox <gi...@apache.org>.
zentol commented on issue #10982: [FLINK-15683][docs] Restructure Configuration page
URL: https://github.com/apache/flink/pull/10982#issuecomment-580878570
> About excluded options: I think I excluded only options that were previously [ ... ] not recommended any more.
Looking at the affected options (`ssl.*`, `local.number-resourcemanager`) there was,_and _still is_, no indication that they aren't recommended anymore. Anyone looking at the option now just sees a random exclude that may have been added for a myriad of reasons.
Hence my question; all I saw was a perfectly fine looking option being excluded from the docs.
If the ssl.* options aren't supposed to be used anymore they should properly deprecated, likely with deprecated keys on the new options, as should the web option, as should `local.number-resourcemanager` since (apparently) it isn't even used anymore.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] StephanEwen commented on issue #10982: [FLINK-15683][docs]
Restructure Configuration page
Posted by GitBox <gi...@apache.org>.
StephanEwen commented on issue #10982: [FLINK-15683][docs] Restructure Configuration page
URL: https://github.com/apache/flink/pull/10982#issuecomment-580943075
Pushed a fix addressing the latest comments.
> If the ssl.* options aren't supposed to be used anymore they should properly deprecated, likely with deprecated keys on the new options, as should the web option, as should `local.number-resourcemanager` since (apparently) it isn't even used anymore.
- I think the SSL options are slightly more complex to resolve than just with deprecated keys. That's why I went with only removing them from the config section for now.
- The `local.number-resourcemanager` is indeed not used any more, added a `@Deprecated` instead.
- The `web.address` option should have been deprecated before (probably overlooked back then). As far as I can tell they are also unused (only referenced as fallback keys).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10982: [FLINK-15683][docs]
Restructure Configuration page
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10982: [FLINK-15683][docs] Restructure Configuration page
URL: https://github.com/apache/flink/pull/10982#issuecomment-580670279
<!--
Meta data
Hash:227476016717c1da4d21aaa3c9bb1e14b47b0e4f Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:227476016717c1da4d21aaa3c9bb1e14b47b0e4f
-->
## CI report:
* 227476016717c1da4d21aaa3c9bb1e14b47b0e4f UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zentol edited a comment on issue #10982:
[FLINK-15683][docs] Restructure Configuration page
Posted by GitBox <gi...@apache.org>.
zentol edited a comment on issue #10982: [FLINK-15683][docs] Restructure Configuration page
URL: https://github.com/apache/flink/pull/10982#issuecomment-580710330
While the separate into common/expert options makes sense, it seems quite inconvenient to not have them in unified form _somewhere_. Having to scoll up/down to get a full overview over related options can be rather tiresome :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10982:
[FLINK-15683][docs] Restructure Configuration page
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10982: [FLINK-15683][docs] Restructure Configuration page
URL: https://github.com/apache/flink/pull/10982#issuecomment-580670279
<!--
Meta data
Hash:227476016717c1da4d21aaa3c9bb1e14b47b0e4f Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/146897292 TriggerType:PUSH TriggerID:227476016717c1da4d21aaa3c9bb1e14b47b0e4f
Hash:227476016717c1da4d21aaa3c9bb1e14b47b0e4f Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4712 TriggerType:PUSH TriggerID:227476016717c1da4d21aaa3c9bb1e14b47b0e4f
Hash:02696f5cee5c1ae7e1fc473992648e56460e7257 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/146901924 TriggerType:PUSH TriggerID:02696f5cee5c1ae7e1fc473992648e56460e7257
Hash:02696f5cee5c1ae7e1fc473992648e56460e7257 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4717 TriggerType:PUSH TriggerID:02696f5cee5c1ae7e1fc473992648e56460e7257
Hash:87b11249448e44d97567fd8dd23bbf1acd9800e1 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:87b11249448e44d97567fd8dd23bbf1acd9800e1
-->
## CI report:
* 227476016717c1da4d21aaa3c9bb1e14b47b0e4f Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/146897292) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4712)
* 02696f5cee5c1ae7e1fc473992648e56460e7257 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/146901924) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4717)
* 87b11249448e44d97567fd8dd23bbf1acd9800e1 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10982:
[FLINK-15683][docs] Restructure Configuration page
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10982: [FLINK-15683][docs] Restructure Configuration page
URL: https://github.com/apache/flink/pull/10982#issuecomment-580670279
<!--
Meta data
Hash:227476016717c1da4d21aaa3c9bb1e14b47b0e4f Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/146897292 TriggerType:PUSH TriggerID:227476016717c1da4d21aaa3c9bb1e14b47b0e4f
Hash:227476016717c1da4d21aaa3c9bb1e14b47b0e4f Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4712 TriggerType:PUSH TriggerID:227476016717c1da4d21aaa3c9bb1e14b47b0e4f
Hash:02696f5cee5c1ae7e1fc473992648e56460e7257 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/146901924 TriggerType:PUSH TriggerID:02696f5cee5c1ae7e1fc473992648e56460e7257
Hash:02696f5cee5c1ae7e1fc473992648e56460e7257 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4717 TriggerType:PUSH TriggerID:02696f5cee5c1ae7e1fc473992648e56460e7257
Hash:87b11249448e44d97567fd8dd23bbf1acd9800e1 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/146965824 TriggerType:PUSH TriggerID:87b11249448e44d97567fd8dd23bbf1acd9800e1
Hash:87b11249448e44d97567fd8dd23bbf1acd9800e1 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4741 TriggerType:PUSH TriggerID:87b11249448e44d97567fd8dd23bbf1acd9800e1
Hash:3129d7f85d1ed3469b87ebe5813f035d1092d195 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/147001893 TriggerType:PUSH TriggerID:3129d7f85d1ed3469b87ebe5813f035d1092d195
Hash:3129d7f85d1ed3469b87ebe5813f035d1092d195 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4743 TriggerType:PUSH TriggerID:3129d7f85d1ed3469b87ebe5813f035d1092d195
-->
## CI report:
* 227476016717c1da4d21aaa3c9bb1e14b47b0e4f Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/146897292) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4712)
* 02696f5cee5c1ae7e1fc473992648e56460e7257 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/146901924) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4717)
* 87b11249448e44d97567fd8dd23bbf1acd9800e1 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/146965824) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4741)
* 3129d7f85d1ed3469b87ebe5813f035d1092d195 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/147001893) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4743)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] StephanEwen commented on a change in pull request #10982:
[FLINK-15683][docs] Restructure Configuration page
Posted by GitBox <gi...@apache.org>.
StephanEwen commented on a change in pull request #10982: [FLINK-15683][docs] Restructure Configuration page
URL: https://github.com/apache/flink/pull/10982#discussion_r373549712
##########
File path: flink-core/src/main/java/org/apache/flink/configuration/SecurityOptions.java
##########
@@ -33,34 +30,33 @@
/**
* The set of configuration options relating to security.
*/
-@PublicEvolving
-@ConfigGroups(groups = {
- @ConfigGroup(name = "Kerberos", keyPrefix = "security.kerberos"),
Review comment:
No specific reason. It is rework step by step. Not everything is migrated in the first step.
At the moment there are still parts that are generated by Class / ConfigGroup, while others are generated by Section option.
In the long run, I would suggest to do everything by section option, that is simpler. But I didn't want just do this without doing a this first rework and see how this model serves us.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] StephanEwen edited a comment on issue #10982:
[FLINK-15683][docs] Restructure Configuration page
Posted by GitBox <gi...@apache.org>.
StephanEwen edited a comment on issue #10982: [FLINK-15683][docs] Restructure Configuration page
URL: https://github.com/apache/flink/pull/10982#issuecomment-580787500
About the layout / splitting. Would be happy if someone would make another pass after that and further improve this. The stat here is the best that came to my mind and it should already be much better than what we have at the moment, the benefits outweigh the problems by far, so would like to not hold it back for now.
About excluded options: I think I excluded only options that were previously also deprecated / not recommended any more.
- web.* options subsumed by rest.*
- ssl.* options that should rather be ssl.internal.* and ssl.rest.*
- miscellaneous previous oversights.
Do you see some that I accidentally excluded?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services