You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2015/08/04 01:12:23 UTC
Review Request 37055: Added Image to Volume as one of the sources.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37055/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman, Timothy Chen, and Vinod Kone.
Repository: mesos
Description
-------
Added Image to Volume as one of the sources.
See the motivation here: https://docs.google.com/document/d/1n2emC2ruTMur5nURvLgGYJxuP-tgBwgLDrmg_17QSmA/edit#
Diffs
-----
include/mesos/mesos.proto a6748d1cd82238f005c6a49c70d22d095462f1ba
Diff: https://reviews.apache.org/r/37055/diff/
Testing
-------
make check
Thanks,
Jie Yu
Re: Review Request 37055: Added Image to Volume as one of the sources.
Posted by Jiang Yan Xu <ya...@jxu.me>.
> On Aug. 5, 2015, 4:43 p.m., Timothy Chen wrote:
> > include/mesos/mesos.proto, line 1254
> > <https://reviews.apache.org/r/37055/diff/1/?file=1028034#file1028034line1254>
> >
> > Should we add some commets around the Image?
> > Perhaps something like:
> >
> > // Image that will be used to provision a new root filesystem by the Image provisioner.
This reads like there is only one provisioner. Maybe just
```
// Image that will be used to provision a new root filesystem.
```
- Jiang Yan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37055/#review94327
-----------------------------------------------------------
On Aug. 3, 2015, 4:12 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37055/
> -----------------------------------------------------------
>
> (Updated Aug. 3, 2015, 4:12 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Timothy Chen, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added Image to Volume as one of the sources.
>
> See the motivation here: https://docs.google.com/document/d/1n2emC2ruTMur5nURvLgGYJxuP-tgBwgLDrmg_17QSmA/edit#
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto a6748d1cd82238f005c6a49c70d22d095462f1ba
>
> Diff: https://reviews.apache.org/r/37055/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 37055: Added Image to Volume as one of the sources.
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37055/#review94327
-----------------------------------------------------------
Ship it!
Ship It!
include/mesos/mesos.proto (line 1247)
<https://reviews.apache.org/r/37055/#comment148886>
Should we add some commets around the Image?
Perhaps something like:
// Image that will be used to provision a new root filesystem by the Image provisioner.
- Timothy Chen
On Aug. 3, 2015, 11:12 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37055/
> -----------------------------------------------------------
>
> (Updated Aug. 3, 2015, 11:12 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Timothy Chen, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added Image to Volume as one of the sources.
>
> See the motivation here: https://docs.google.com/document/d/1n2emC2ruTMur5nURvLgGYJxuP-tgBwgLDrmg_17QSmA/edit#
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto a6748d1cd82238f005c6a49c70d22d095462f1ba
>
> Diff: https://reviews.apache.org/r/37055/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>