You are viewing a plain text version of this content. The canonical link for it is here.
Posted to log4j-dev@logging.apache.org by ce...@apache.org on 2005/01/19 19:56:48 UTC

cvs commit: logging-log4j/src/java/org/apache/log4j/chainsaw RuleMediator.java

ceki        2005/01/19 10:56:48

  Modified:    src/java/org/apache/log4j/rule Rule.java
               src/java/org/apache/log4j/filter ExpressionFilter.java
               src/java/org/apache/log4j/chainsaw RuleMediator.java
  Log:
  Javdoc or cosmetic changes
  
  Revision  Changes    Path
  1.3       +10 -8     logging-log4j/src/java/org/apache/log4j/rule/Rule.java
  
  Index: Rule.java
  ===================================================================
  RCS file: /home/cvs/logging-log4j/src/java/org/apache/log4j/rule/Rule.java,v
  retrieving revision 1.2
  retrieving revision 1.3
  diff -u -r1.2 -r1.3
  --- Rule.java	27 Feb 2004 16:47:34 -0000	1.2
  +++ Rule.java	19 Jan 2005 18:56:48 -0000	1.3
  @@ -33,9 +33,10 @@
    */
   public interface Rule {
     /**
  -   * Returns true if this implementation of the rule accepts the LoggingEvent, or false if not.
  +   * Returns true if this implementation of the rule accepts the LoggingEvent, 
  +   * or false if not.
      *
  -   * What True/False means can be client-specific.
  +   * <p>What True/False means can be client-specific.
      *
      * @param e LoggingEvent this instance will evaluate
      * @return true if this Rule instance accepts the event, otherwise false.
  @@ -43,15 +44,16 @@
     public boolean evaluate(LoggingEvent e);
   
     /**
  -   * Adds a PropertyChangeListener to this instance, which is notified when underlying Rule
  -   * information has changed. (there are no specific property name events).
  -   * @param l
  +   * Adds a PropertyChangeListener to this instance, which is notified when 
  +   * underlying Rule information has changed. 
  +   * (there are no specific property name events).
  +   * @param listener
      */
  -  public void addPropertyChangeListener(PropertyChangeListener l);
  +  public void addPropertyChangeListener(PropertyChangeListener listener);
   
     /**
      * Removes a known PropertyChangeListener from this Rule.
  -   * @param l
  +   * @param listener
      */
  -  public void removePropertyChangeListener(PropertyChangeListener l);
  +  public void removePropertyChangeListener(PropertyChangeListener listener);
   }
  
  
  
  1.2       +9 -8      logging-log4j/src/java/org/apache/log4j/filter/ExpressionFilter.java
  
  Index: ExpressionFilter.java
  ===================================================================
  RCS file: /home/cvs/logging-log4j/src/java/org/apache/log4j/filter/ExpressionFilter.java,v
  retrieving revision 1.1
  retrieving revision 1.2
  diff -u -r1.1 -r1.2
  --- ExpressionFilter.java	3 Jan 2005 11:01:02 -0000	1.1
  +++ ExpressionFilter.java	19 Jan 2005 18:56:48 -0000	1.2
  @@ -23,17 +23,18 @@
   
   
   /**
  - *A filter supporting complex expressions - supports both infix and postfix expressions 
  - *(infix expressions must first be converted to postfix prior to processing).
  + *A filter supporting complex expressions - supports both infix and postfix 
  + * expressions (infix expressions must first be converted to postfix prior 
  + * to processing).
    *
  - *See <code>org.apache.log4j.chainsaw.LoggingEventFieldResolver.java</code> 
  - *for the correct names for logging event fields used when building expressions.
  + * <p>See <code>org.apache.log4j.chainsaw.LoggingEventFieldResolver.java</code> 
  + * for the correct names for logging event fields used when building expressions.
    *
  - *See <org.apache.log4j.chainsaw.rule</code> package for a list of available rules which can
  - *be applied using the expression syntax.
  + * <p>See <org.apache.log4j.chainsaw.rule</code> package for a list of available
  + * rules which can be applied using the expression syntax.
    *
  - *See <code>org.apache.log4j.chainsaw.RuleFactory</code> for the symbols used to 
  - *activate the corresponding rules.
  + * <p>See <code>org.apache.log4j.chainsaw.RuleFactory</code> for the symbols 
  + * used to activate the corresponding rules.
    *
    *NOTE:  Grouping using parentheses is supported - all tokens must be separated by spaces, and
    *operands which contain spaces are not yet supported.
  
  
  
  1.7       +11 -8     logging-log4j/src/java/org/apache/log4j/chainsaw/RuleMediator.java
  
  Index: RuleMediator.java
  ===================================================================
  RCS file: /home/cvs/logging-log4j/src/java/org/apache/log4j/chainsaw/RuleMediator.java,v
  retrieving revision 1.6
  retrieving revision 1.7
  diff -u -r1.6 -r1.7
  --- RuleMediator.java	24 Nov 2004 08:17:01 -0000	1.6
  +++ RuleMediator.java	19 Jan 2005 18:56:48 -0000	1.7
  @@ -25,18 +25,21 @@
   
   
   /**
  - * A mediator class that implements the Rule interface, by combining several optional
  - * rules used by Chainsaw's filtering GUI's into a single Rule.
  + * A mediator class that implements the Rule interface, by combining several 
  + * optional rules used by Chainsaw's filtering GUI's into a single Rule.
    *
  - * This class is based upon the concept of Inclusion, Exclusion and Refinement.
  - * By default, this class accepts all events by returning true as part of the Rule interface, unless
  - * the Inclusion/Exclusion/Refinement sub-rules have been configured.
  + * <p>This class is based upon the concept of Inclusion, Exclusion and Refinement.
  + * By default, this class accepts all events by returning true as part of the 
  + * Rule interface, unless the Inclusion/Exclusion/Refinement sub-rules have been
  + * configured.
    *
  - * The sub-rules are queried in this order: Inclusion, Refinement, Exclusion.  If any are null, that particular
  - * sub-rule is not queried.  If any of the sub-rules returns false, this mediator returns false immediately, otherwise
  + * <p>The sub-rules are queried in this order: Inclusion, Refinement, Exclusion.  
  + * If any are null, that particular sub-rule is not queried.  If any of the 
  + * sub-rules returns false, this mediator returns false immediately, otherwise
    * they are queried in that order to ensure the overall rule evaluates.
    *
  - * Setting the individual sub-rules propagates a PropertyChangeEvent as per standard Java beans principles.
  + * <p>Setting the individual sub-rules propagates a PropertyChangeEvent as per 
  + * standard Java beans principles.
    *
    * @author Paul Smith <ps...@apache.org>
    * @author Scott Deboy <sd...@apache.org>
  
  
  

---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org