You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ti...@apache.org on 2022/06/12 14:31:31 UTC
svn commit: r1901848 - /pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/graphics/optionalcontent/PDOptionalContentMembershipDictionary.java
Author: tilman
Date: Sun Jun 12 14:31:30 2022
New Revision: 1901848
URL: http://svn.apache.org/viewvc?rev=1901848&view=rev
Log:
PDFBOX-4892: optimize, as suggested by Valery Bokov
Modified:
pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/graphics/optionalcontent/PDOptionalContentMembershipDictionary.java
Modified: pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/graphics/optionalcontent/PDOptionalContentMembershipDictionary.java
URL: http://svn.apache.org/viewvc/pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/graphics/optionalcontent/PDOptionalContentMembershipDictionary.java?rev=1901848&r1=1901847&r2=1901848&view=diff
==============================================================================
--- pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/graphics/optionalcontent/PDOptionalContentMembershipDictionary.java (original)
+++ pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/graphics/optionalcontent/PDOptionalContentMembershipDictionary.java Sun Jun 12 14:31:30 2022
@@ -17,6 +17,7 @@
package org.apache.pdfbox.pdmodel.graphics.optionalcontent;
import java.util.ArrayList;
+import java.util.Collections;
import java.util.List;
import org.apache.pdfbox.cos.COSArray;
import org.apache.pdfbox.cos.COSBase;
@@ -60,15 +61,16 @@ public class PDOptionalContentMembership
*/
public List<PDPropertyList> getOCGs()
{
- List<PDPropertyList> list = new ArrayList<PDPropertyList>();
COSBase base = dict.getDictionaryObject(COSName.OCGS);
if (base instanceof COSDictionary)
{
- list.add(PDPropertyList.create((COSDictionary) base));
+ return Collections.singletonList(PDPropertyList.create((COSDictionary) base));
}
- else if (base instanceof COSArray)
+
+ if (base instanceof COSArray)
{
COSArray ar = (COSArray) base;
+ List<PDPropertyList> list = new ArrayList<PDPropertyList>();
for (int i = 0; i < ar.size(); ++i)
{
COSBase elem = ar.getObject(i);
@@ -77,8 +79,10 @@ public class PDOptionalContentMembership
list.add(PDPropertyList.create((COSDictionary) elem));
}
}
+ return list;
}
- return list;
+
+ return Collections.emptyList();
}
/**