[GitHub] [incubator-pekko] pjfanning commented on a diff in pull request #77: try to add license and notice to jars

[GitBox <gi...@apache.org>]

pjfanning commented on code in PR #77:
URL: https://github.com/apache/incubator-pekko/pull/77#discussion_r1056684712


##########
NOTICE:
##########
@@ -0,0 +1,13 @@
+Apache Pekko
+Copyright 2022 The Apache Software Foundation
+
+This product includes software developed at
+The Apache Software Foundation (https://www.apache.org/).
+
+This product contains significant parts that were originally based on software from Lightbend (Akka <https://akka.io/>).
+Copyright (C) 2009-2022 Lightbend Inc. <https://www.lightbend.com>
+
+Apache Pekko is a derived from Akka 2.6.x, the last version that was distributed under the
+Apache License, Version 2.0 License.
+
+`pekko-protobuf` includes protobuf v2.5.0 code developed by Google Inc.

Review Comment:
   @justinmclean I was basing this on other ASF project NOTICE files that often mention code from other projects that has been included in that project. Examples:
   * https://github.com/apache/spark/blob/master/NOTICE
   * https://github.com/apache/poi/blob/trunk/legal/NOTICE
   * https://github.com/apache/xmlbeans/blob/trunk/NOTICE.txt
   
   For Drill, the NOTICE says the other licenses are in the main LICENSE file
   * https://github.com/apache/drill/blob/master/LICENSE
   
   So I guess, there are differences in approach. Could you suggest if we need to acknowledge the Google copyright at all? We are planning to keep the code headers that already acknowledge this.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org