[GitHub] yzhliu commented on a change in pull request #11844: [MXNET-689] add DataDesc type for the Scala Package

[GitBox <gi...@apache.org>]

yzhliu commented on a change in pull request #11844: [MXNET-689] add DataDesc type for the Scala Package
URL: https://github.com/apache/incubator-mxnet/pull/11844#discussion_r208717672
 
 

 ##########
 File path: scala-package/core/src/main/scala/org/apache/mxnet/DType.scala
 ##########
 @@ -35,4 +35,13 @@ object DType extends Enumeration {
       case DType.Unknown => 0
     }
   }
+  private[mxnet] def getType(dtypeStr: String): DType = {
+    dtypeStr match {
+      case "UInt8" => DType.UInt8
+      case "Int32" => DType.Int32
+      case "Float16" => DType.Float16
+      case "Float32" => DType.Float32
+      case "Float64" => DType.Float64
 
 Review comment:
   otherwise throw IllegalArgumentException

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services