[jira] Issue Comment Edited: (GERONIMO-4646) Warn during a war deployment, if no WEB-INF/web.xml file is found

["Rex Wang (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GERONIMO-4646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12739321#action_12739321 ] 

Rex Wang edited comment on GERONIMO-4646 at 8/4/09 7:57 PM:
------------------------------------------------------------

Hi Victor, just have a look at your patch, I think you should not provide the same warning message as the missing geronimo-web.xml:
+            log.warn("Web application " + targetPath + " does not contain a WEB-INF/web.xml deployment plan.  This may or may not be a problem, depending on whether you have things like resource references that need to be resolved.  You can also give the deployer a separate deployment plan file on the command line.");

The web.xml is not a geronimo deployment plan, so you can not give the deployer a separate web.xml file on anywhere..


-Rex


      was (Author: rwonly):
    Hi Victor, just have a look at your patch, I think you should not provide the same warning message as the missing geronimo-web.xml:
+            log.warn("Web application " + targetPath + " does not contain a WEB-INF/web.xml deployment plan.  This may or may not be a problem, depending on whether you have things like resource references that need to be resolved.  You can also give the deployer a separate deployment plan file on the command line.");

The web.xml is not a geronimo deployment plan, so you can not give the deployer a separate deployment plan file on anywhere..


-Rex

  
> Warn during a war deployment, if no WEB-INF/web.xml file is found
> -----------------------------------------------------------------
>
>                 Key: GERONIMO-4646
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-4646
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>    Affects Versions: 2.1.4, 2.2
>            Reporter: Kevan Miller
>             Fix For: 2.1.5, 2.2
>
>         Attachments: GERONIMO-4646.patch, GERONIMO-4646.PNG
>
>
> Per the specs, a WAR without a WEB-INF/web.xml is a valid WAR file. However, it's also an indication of a poorly formatted WAR. It seems like it would be useful to log a warning, if we don't find a WEB-INF/web.xml file, just like we log a WARN, if a geronimo-web.xml file is not found:
> 2009-05-25 22:13:12,535 WARN  [TomcatModuleBuilder] Web application . does not contain a WEB-INF/geronimo-web.xml deployment plan.  This may or may not be a problem, depending on whether you have things like resource references that need to be resolved.  You can also give the deployer a separate deployment plan file on the command line.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.