[GitHub] [solr] sonatype-lift[bot] commented on a change in pull request #255: SOLR-15560: Optimize JavaBinCodec encode/decode performance.

[GitBox <gi...@apache.org>]

sonatype-lift[bot] commented on a change in pull request #255:
URL: https://github.com/apache/solr/pull/255#discussion_r687111935



##########
File path: solr/solrj/src/java/org/apache/solr/common/util/JavaBinCodec.java
##########
@@ -954,8 +1063,8 @@ protected CharSequence readUtf8(DataInputInputStream dis) throws IOException {
   protected CharSequence readUtf8(DataInputInputStream dis, int sz) throws IOException {
     ByteArrayUtf8CharSequence result = new ByteArrayUtf8CharSequence(null,0,0);
     if(dis.readDirectUtf8(result, sz)){
-     result.stringProvider= getStringProvider();
-     return result;
+      result.stringProvider= getStringProvider();
+      return result;
     }
 
     if (sz > MAX_UTF8_SZ) return _readStr(dis, null, sz);

Review comment:
       *NULL_DEREFERENCE:*  object `null` is dereferenced by call to `_readStr(...)` at line 1070.
   (at-me [in a reply](https://help.sonatype.com/lift) with `help` or `ignore`)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org