You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org> on 2021/02/19 13:14:27 UTC
[Impala-ASF-CR] IMPALA-10496: Remove checking port in FLAGS saml2 sp callback url
Csaba Ringhofer has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17087
Change subject: IMPALA-10496: Remove checking port in FLAGS_saml2_sp_callback_url
......................................................................
IMPALA-10496: Remove checking port in FLAGS_saml2_sp_callback_url
Enforcing that the port in FLAGS_saml2_sp_callback_url must be the same
as hs2_http_port causes problems if the port is mapped, e.g. in
containerized setting.
Change-Id: I2534b7a1a2bf16bf48ba533dc13fd300f690f4e5
---
M be/src/rpc/authentication.cc
1 file changed, 5 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/87/17087/1
--
To view, visit http://gerrit.cloudera.org:8080/17087
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2534b7a1a2bf16bf48ba533dc13fd300f690f4e5
Gerrit-Change-Number: 17087
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
[Impala-ASF-CR] IMPALA-10496: Remove checking port in FLAGS saml2 sp callback url
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17087 )
Change subject: IMPALA-10496: Remove checking port in FLAGS_saml2_sp_callback_url
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/17087
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2534b7a1a2bf16bf48ba533dc13fd300f690f4e5
Gerrit-Change-Number: 17087
Gerrit-PatchSet: 3
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 19 Feb 2021 18:59:26 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10496: Remove checking port in FLAGS saml2 sp callback url
Posted by "Attila Jeges (Code Review)" <ge...@cloudera.org>.
Attila Jeges has posted comments on this change. ( http://gerrit.cloudera.org:8080/17087 )
Change subject: IMPALA-10496: Remove checking port in FLAGS_saml2_sp_callback_url
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/17087
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2534b7a1a2bf16bf48ba533dc13fd300f690f4e5
Gerrit-Change-Number: 17087
Gerrit-PatchSet: 2
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 19 Feb 2021 13:24:58 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10496: Remove checking port in FLAGS saml2 sp callback url
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17087 )
Change subject: IMPALA-10496: Remove checking port in FLAGS_saml2_sp_callback_url
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6903/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/17087
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2534b7a1a2bf16bf48ba533dc13fd300f690f4e5
Gerrit-Change-Number: 17087
Gerrit-PatchSet: 3
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 19 Feb 2021 13:26:38 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10496: Remove checking port in FLAGS saml2 sp callback url
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17087 )
Change subject: IMPALA-10496: Remove checking port in FLAGS_saml2_sp_callback_url
......................................................................
Patch Set 1:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/8170/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/17087
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2534b7a1a2bf16bf48ba533dc13fd300f690f4e5
Gerrit-Change-Number: 17087
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 19 Feb 2021 13:24:38 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10496: Remove checking port in FLAGS saml2 sp callback url
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/17087
to look at the new patch set (#2).
Change subject: IMPALA-10496: Remove checking port in FLAGS_saml2_sp_callback_url
......................................................................
IMPALA-10496: Remove checking port in FLAGS_saml2_sp_callback_url
Enforcing that the port in FLAGS_saml2_sp_callback_url must be the same
as hs2_http_port causes problems if the port is mapped, e.g. in
containerized setting.
Change-Id: I2534b7a1a2bf16bf48ba533dc13fd300f690f4e5
---
M be/src/rpc/authentication.cc
1 file changed, 4 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/87/17087/2
--
To view, visit http://gerrit.cloudera.org:8080/17087
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2534b7a1a2bf16bf48ba533dc13fd300f690f4e5
Gerrit-Change-Number: 17087
Gerrit-PatchSet: 2
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-10496: Remove checking port in FLAGS saml2 sp callback url
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17087 )
Change subject: IMPALA-10496: Remove checking port in FLAGS_saml2_sp_callback_url
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/17087
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2534b7a1a2bf16bf48ba533dc13fd300f690f4e5
Gerrit-Change-Number: 17087
Gerrit-PatchSet: 3
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 19 Feb 2021 13:26:37 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10496: Remove checking port in FLAGS saml2 sp callback url
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17087 )
Change subject: IMPALA-10496: Remove checking port in FLAGS_saml2_sp_callback_url
......................................................................
IMPALA-10496: Remove checking port in FLAGS_saml2_sp_callback_url
Enforcing that the port in FLAGS_saml2_sp_callback_url must be the same
as hs2_http_port causes problems if the port is mapped, e.g. in
containerized setting.
Change-Id: I2534b7a1a2bf16bf48ba533dc13fd300f690f4e5
Reviewed-on: http://gerrit.cloudera.org:8080/17087
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/rpc/authentication.cc
1 file changed, 4 insertions(+), 5 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/17087
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I2534b7a1a2bf16bf48ba533dc13fd300f690f4e5
Gerrit-Change-Number: 17087
Gerrit-PatchSet: 4
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-10496: Remove checking port in FLAGS saml2 sp callback url
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17087 )
Change subject: IMPALA-10496: Remove checking port in FLAGS_saml2_sp_callback_url
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/8171/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/17087
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2534b7a1a2bf16bf48ba533dc13fd300f690f4e5
Gerrit-Change-Number: 17087
Gerrit-PatchSet: 2
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 19 Feb 2021 13:35:43 +0000
Gerrit-HasComments: No