You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by ah...@apache.org on 2020/02/17 23:08:44 UTC

[commons-numbers] 01/03: Update checkstyle

This is an automated email from the ASF dual-hosted git repository.

aherbert pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-numbers.git

commit 0bc3540a5e345095506941fa9babbff57a70fe3e
Author: Alex Herbert <ah...@apache.org>
AuthorDate: Mon Feb 17 22:58:44 2020 +0000

    Update checkstyle
    
    maven plugin 3.0.0 -> 3.1.0
    Dependency 8.20 -> 8.29
---
 pom.xml                                      |  4 ++--
 src/main/resources/checkstyle/checkstyle.xml | 21 +++++++++------------
 2 files changed, 11 insertions(+), 14 deletions(-)

diff --git a/pom.xml b/pom.xml
index 1d73f85..74b9343 100644
--- a/pom.xml
+++ b/pom.xml
@@ -58,8 +58,8 @@
     <maven.compiler.target>1.8</maven.compiler.target>
     <numbers.pmd.version>3.12.0</numbers.pmd.version>
     <numbers.pmd.dep.version>6.19.0</numbers.pmd.dep.version>
-    <numbers.checkstyle.version>3.0.0</numbers.checkstyle.version>
-    <numbers.checkstyle.dep.version>8.20</numbers.checkstyle.dep.version>
+    <numbers.checkstyle.version>3.1.0</numbers.checkstyle.version>
+    <numbers.checkstyle.dep.version>8.29</numbers.checkstyle.dep.version>
     <numbers.mathjax.version>2.7.2</numbers.mathjax.version>
     <numbers.junit.bom.version>5.4.2</numbers.junit.bom.version>
     <numbers.commons.math3.version>3.6.1</numbers.commons.math3.version>
diff --git a/src/main/resources/checkstyle/checkstyle.xml b/src/main/resources/checkstyle/checkstyle.xml
index 2fb1cd6..3af3265 100644
--- a/src/main/resources/checkstyle/checkstyle.xml
+++ b/src/main/resources/checkstyle/checkstyle.xml
@@ -22,7 +22,7 @@
           "https://checkstyle.org/dtds/configuration_1_3.dtd">
 
 <!--
-  Commons RNG customization of default Checkstyle behaviour:
+  Commons Numbers customization of default Checkstyle behaviour:
   https://github.com/checkstyle/checkstyle/blob/master/src/main/resources/sun_checks.xml
 -->
 <module name="Checker">
@@ -57,6 +57,12 @@
   <!-- Checks for Size Violations. -->
   <!-- See http://checkstyle.sourceforge.net/config_sizes.html -->
   <module name="FileLength" />
+  <module name="LineLength">
+    <property name="fileExtensions" value="java"/>
+    <!-- Ignore lines that begin with " * ", such as within a Javadoc comment. -->
+    <property name="ignorePattern" value="^ *\* *[^ ]"/>
+    <property name="max" value="120"/>
+  </module>
 
   <!-- Checks for whitespace -->
   <!-- See http://checkstyle.sourceforge.net/config_whitespace.html -->
@@ -81,12 +87,8 @@
 
     <!-- Checks for Javadoc comments. -->
     <!-- See http://checkstyle.sourceforge.net/config_javadoc.html -->
-    <!-- Require method javadocs, allow undeclared RTE -->
-    <module name="JavadocMethod">
-      <property name="allowUndeclaredRTE" value="true"/>
-      <property name="allowThrowsTagsForSubclasses" value="true"/>
-      <property name="validateThrows" value="false"/>
-    </module>
+    <module name="InvalidJavadocPosition"/>
+    <module name="JavadocMethod" />
     <module name="JavadocType" />
     <module name="JavadocVariable" />
     <module name="JavadocStyle" />
@@ -115,11 +117,6 @@
 
     <!-- Checks for Size Violations. -->
     <!-- See http://checkstyle.sourceforge.net/config_sizes.html -->
-    <module name="LineLength">
-      <!-- Ignore lines that begin with " * ", such as within a Javadoc comment. -->
-      <property name="ignorePattern" value="^ *\* *[^ ]"/>
-      <property name="max" value="120"/>
-    </module>
     <module name="MethodLength" />
     <module name="ParameterNumber" />