You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by se...@apache.org on 2009/04/15 13:19:16 UTC
svn commit: r765138 - in
/commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/archivers:
ar/ArArchiveInputStream.java cpio/CpioArchiveOutputStream.java
Author: sebb
Date: Wed Apr 15 11:19:16 2009
New Revision: 765138
URL: http://svn.apache.org/viewvc?rev=765138&view=rev
Log:
Missing/misplaced TODOs for default charset
Modified:
commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/archivers/ar/ArArchiveInputStream.java
commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/archivers/cpio/CpioArchiveOutputStream.java
Modified: commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/archivers/ar/ArArchiveInputStream.java
URL: http://svn.apache.org/viewvc/commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/archivers/ar/ArArchiveInputStream.java?rev=765138&r1=765137&r2=765138&view=diff
==============================================================================
--- commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/archivers/ar/ArArchiveInputStream.java (original)
+++ commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/archivers/ar/ArArchiveInputStream.java Wed Apr 15 11:19:16 2009
@@ -129,7 +129,7 @@
entryOffset = offset;
// SVR4/GNU adds a trailing "/" to names
- String temp=new String(name).trim();
+ String temp=new String(name).trim(); // TODO is it correct to use the default charset here?
if (temp.endsWith("/")){
temp=temp.substring(0, temp.length()-1);
}
Modified: commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/archivers/cpio/CpioArchiveOutputStream.java
URL: http://svn.apache.org/viewvc/commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/archivers/cpio/CpioArchiveOutputStream.java?rev=765138&r1=765137&r2=765138&view=diff
==============================================================================
--- commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/archivers/cpio/CpioArchiveOutputStream.java (original)
+++ commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/archivers/cpio/CpioArchiveOutputStream.java Wed Apr 15 11:19:16 2009
@@ -377,8 +377,8 @@
}
private void writeCString(final String str) throws IOException {
- out.write(str.getBytes());
- out.write('\0'); // TODO is it correct to use the default charset here?
+ out.write(str.getBytes()); // TODO is it correct to use the default charset here?
+ out.write('\0');
}
public ArchiveEntry createArchiveEntry(File inputFile, String entryName)