You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@bookkeeper.apache.org by "lhotari (via GitHub)" <gi...@apache.org> on 2023/05/29 07:16:23 UTC

[GitHub] [bookkeeper] lhotari opened a new pull request, #3975: Upgrade Netty to 4.1.93.Final

lhotari opened a new pull request, #3975:
URL: https://github.com/apache/bookkeeper/pull/3975

   ### Changes & Motivation
   
   - Upgrade Netty to 4.1.93.Final and io_uring transport to 0.0.21.Final
     - includes netty-tcnative 2.0.61.Final
   
   Highlights:
   - Upgrade to latest netty-tcnative to fix memory leak in 4.1.93.Final https://github.com/netty/netty/pull/13375
   - native SSL implementation fixes in 4.1.91.Final https://twitter.com/normanmaurer/status/1642884593522032640
   - performance improvements in 4.1.90.Final and 4.1.92.Final https://twitter.com/normanmaurer/status/1635671472566837248 https://twitter.com/normanmaurer/status/1650816576885538816
   
   Release notes:
   https://netty.io/news/2023/03/14/4-1-90-Final.html https://netty.io/news/2023/04/03/4-1-91-Final.html https://netty.io/news/2023/04/25/4-1-92-Final.html https://netty.io/news/2023/05/25/4-1-93-Final.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bookkeeper] eolivelli commented on pull request #3975: Upgrade Netty to 4.1.93.Final

Posted by "eolivelli (via GitHub)" <gi...@apache.org>.
eolivelli commented on PR #3975:
URL: https://github.com/apache/bookkeeper/pull/3975#issuecomment-1569105398

   we run performance tests daily/weekly against all the Pulsar and we would find regressions
   
   we usually update Netty in the Pulsar repo and automatically the Bookie and the BK client use the new version and it is pretty easy to see of there is a breaking change


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bookkeeper] eolivelli merged pull request #3975: Upgrade Netty to 4.1.93.Final

Posted by "eolivelli (via GitHub)" <gi...@apache.org>.
eolivelli merged PR #3975:
URL: https://github.com/apache/bookkeeper/pull/3975


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bookkeeper] Ghatage commented on pull request #3975: Upgrade Netty to 4.1.93.Final

Posted by "Ghatage (via GitHub)" <gi...@apache.org>.
Ghatage commented on PR #3975:
URL: https://github.com/apache/bookkeeper/pull/3975#issuecomment-1568726463

   @lhotari Just wondering, client performance over the network is super sensitive to netty version changes. At least in our experience. I wonder:
   1. Whats your opinion on this?
   2. What does community do to catch perf regressions etc. in such scenarios.
   
   cc @jvrao @reddycharan 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org