You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2018/08/29 21:19:46 UTC
[GitHub] kristw commented on a change in pull request #5763: [SIP-5]
Refactor rose
kristw commented on a change in pull request #5763: [SIP-5] Refactor rose
URL: https://github.com/apache/incubator-superset/pull/5763#discussion_r213837952
##########
File path: superset/assets/src/visualizations/rose.js
##########
@@ -1,11 +1,29 @@
/* eslint no-use-before-define: ["error", { "functions": false }] */
import d3 from 'd3';
+import PropTypes from 'prop-types';
import nv from 'nvd3';
import { d3TimeFormatPreset } from '../modules/utils';
import { getColorFromScheme } from '../modules/colors';
-
import './rose.css';
+const propTypes = {
+ // Data is an object hashed by numeric value, perhaps timestamp
Review comment:
Good call. Will update
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org