[GitHub] [incubator-pekko-http] Seetaramayya commented on issue #1: Move to upstream parboiled2 dependency

["Seetaramayya (via GitHub)" <gi...@apache.org>]

Seetaramayya commented on issue #1:
URL: https://github.com/apache/incubator-pekko-http/issues/1#issuecomment-1429319060

   ## Approach 1: As Is approach (convert to dependency in `1.1.0`)
   
   (+) As @spangaer mentioned, we can reason about bugs (if there are any) `1.0.0` does not do anything apart from different packaging. No need to worry about performance impacts. 
   (+) No need to run heavy performance benchmarks before releasing
   (-) As @pjfanning mentioned, licence files management would be easy (I really don't know how painful)
   
    ## Approach 2: Convert to dependency right now (in `1.0.0`)
   
   (+) Licence file management would be easy
   (-) IMHO: Performance bench marks needs to be run before releasing 
   (-) Assume underlying dependency `parboiled` has (`functional` or `performance` ) bug which resulted lot of side effects in the system narrow down the issue would be bit more complicated than the approach (I am talking from relative point of view). 
   
   
   I would prefer `Approach 1` unless there is a huge impact on licensing part (I don't know have knowledge in the area). IMHO: With this approach we are separating the concerns 
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org