You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/10/11 22:38:43 UTC

[GitHub] [beam] ibzib commented on a change in pull request #15637: [BEAM-12135] Avoid windowing overhead in Spark global GBK.

ibzib commented on a change in pull request #15637:
URL: https://github.com/apache/beam/pull/15637#discussion_r726613030



##########
File path: runners/spark/src/main/java/org/apache/beam/runners/spark/translation/GroupNonMergingWindowsFunctions.java
##########
@@ -256,4 +257,31 @@ private V decodeValue(byte[] windowedValueBytes) {
           KV.of(key, value), timestamp, window, PaneInfo.ON_TIME_AND_ONLY_FIRING);
     }
   }
+
+  /**
+   * Creates composite key of K and W and group all values for that composite key with Spark's

Review comment:
       Please update the javadoc comment.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org